starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

DynamicModelChoiceField and DynamicModelMultipleChoiceField should accept a model, not queryset #4379

New Issue
Closed
opened 2025-12-29 18:35:26 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:35:26 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Dec 18, 2020).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Replace the queryset keyword argument on DynamicModelChoiceField and DynamicModelMultipleChoiceField with model.

Justification

Since these models fetch available choices using NetBox's REST API, the use of queryset is misleading. The provided queryset isn't actually used when retrieving choices, so calling queryset methods like filter() and prefetch_related() have no impact. Specifying only the base model for the field is simpler and draws attention to the use of query_params for filtering choices.

Originally created by @jeremystretch on GitHub (Dec 18, 2020). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Replace the `queryset` keyword argument on DynamicModelChoiceField and DynamicModelMultipleChoiceField with `model`. ### Justification Since these models fetch available choices using NetBox's REST API, the use of `queryset` is misleading. The provided queryset isn't actually used when retrieving choices, so calling queryset methods like `filter()` and `prefetch_related()` have no impact. Specifying only the base model for the field is simpler and draws attention to the use of `query_params` for filtering choices.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:35:26 +01:00
adam closed this issue 2025-12-29 18:35:26 +01:00
adam commented 2025-12-29 18:35:26 +01:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Feb 2, 2021):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale[bot] commented on GitHub (Feb 2, 2021): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 18:35:27 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 18, 2021):

After making these changes application-wide, the the test suite seems to take ~10-12 seconds longer to run. I'm not sure why this is, but it's probably not worth the effort to chase down. I'm going to abandon this effort as there isn't really anything wrong with just using querysets directly.

@jeremystretch commented on GitHub (Nov 18, 2021): After making these changes application-wide, the the test suite seems to take ~10-12 seconds longer to run. I'm not sure why this is, but it's probably not worth the effort to chase down. I'm going to abandon this effort as there isn't really anything wrong with just using querysets directly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?