starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Counter-intuitive use of icons in column "Tagged" on page VLANs / Device Interfaces #4374

New Issue
Closed
opened 2025-12-29 18:35:23 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:35:23 +01:00
Owner
Copy Link

Originally created by @jbakklund on GitHub (Dec 17, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

  • Python version: 3.7.3
  • NetBox version: 2.10.1

Steps to Reproduce

  1. Create at least one VLAN.
  2. Add this VLAN to a couple of device interfaces, some in access mode, and others as tagged (switchport mode trunk).
  3. Navigate to the VLAN you just created (on page .../ipam/vlans/X/ where X represents the VLANs unique database key).
  4. Click on the tab "Device Interfaces".

Expected Behavior

In the column "Tagged", I would expect to see a kind of positive checkmark or icon for interfaces participating in the given VLAN with its 802.1Q mode set to "Tagged", and a kind of negative icon for interfaces participating in Access Mode.

Observed Behavior

This seems to have been swapped around: Interfaces where the VLAN is actually tagged are listed with a red X, which I interpret as a "No" - this interface is not tagged, while interfaces not being tagged are listed with a green Checkmark, which I interpret as a "Yes" - this one is tagged.

ipam_vlans_x_interfaces

The current use of icons seems counter-intuitive for a column named "Tagged". I think the usage should be swapped around, or the column could be renamed "Access Mode", or simply named "Mode" while using text showing "Access" or "Tagged" instead of the icons.

Originally created by @jbakklund on GitHub (Dec 17, 2020). Originally assigned to: @jeremystretch on GitHub. ### Environment * Python version: 3.7.3 * NetBox version: 2.10.1 ### Steps to Reproduce 1. Create at least one VLAN. 2. Add this VLAN to a couple of device interfaces, some in access mode, and others as tagged (switchport mode trunk). 3. Navigate to the VLAN you just created (on page .../ipam/vlans/X/ where X represents the VLANs unique database key). 4. Click on the tab "Device Interfaces". ### Expected Behavior In the column "Tagged", I would expect to see a kind of positive checkmark or icon for interfaces participating in the given VLAN with its 802.1Q mode set to "Tagged", and a kind of negative icon for interfaces participating in Access Mode. ### Observed Behavior This seems to have been swapped around: Interfaces where the VLAN is actually tagged are listed with a red X, which I interpret as a "No" - this interface is not tagged, while interfaces not being tagged are listed with a green Checkmark, which I interpret as a "Yes" - this one is tagged. ![ipam_vlans_x_interfaces](https://user-images.githubusercontent.com/33431806/102481800-88bd1d80-4062-11eb-8be0-062a9d9fab9e.png) The current use of icons seems counter-intuitive for a column named "Tagged". I think the usage should be swapped around, or the column could be renamed "Access Mode", or simply named "Mode" while using text showing "Access" or "Tagged" instead of the icons.
adam added the type: bugstatus: accepted labels 2025-12-29 18:35:23 +01:00
adam closed this issue 2025-12-29 18:35:23 +01:00
adam commented 2025-12-29 18:35:23 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 17, 2020):

Thank you for the detailed bug report!

@jeremystretch commented on GitHub (Dec 17, 2020): Thank you for the detailed bug report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4374
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?