starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

ConfigContext optimization from #4559 not active for REST API views #4372

New Issue
Closed
opened 2025-12-29 18:35:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:35:22 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Dec 17, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

  • Python version: 3.6.9
  • NetBox version: 2.10.1

Steps to Reproduce

  1. With debug enabled, make a REST API call for /api/dcim/devices/ and inspect the SQL queries being made.

Expected Behavior

Retrieval of ConfigContext data should be optimized per #4559.

Observed Behavior

ConfigContextQuerySetMixin's get_queryset() method is not called because DeviceViewSet inherits first from CustomFieldModelViewSet, which already provides get_queryset() (from the base ViewSet class).

Reversing the order of these parent classes ensures that the optimization provided by ConfigContextQuerySetMixin takes effect.

Originally created by @jeremystretch on GitHub (Dec 17, 2020). Originally assigned to: @jeremystretch on GitHub. ### Environment * Python version: 3.6.9 * NetBox version: 2.10.1 ### Steps to Reproduce 1. With debug enabled, make a REST API call for `/api/dcim/devices/` and inspect the SQL queries being made. ### Expected Behavior Retrieval of ConfigContext data should be optimized per #4559. ### Observed Behavior ConfigContextQuerySetMixin's `get_queryset()` method is not called because DeviceViewSet inherits first from CustomFieldModelViewSet, which already provides `get_queryset()` (from the base ViewSet class). Reversing the order of these parent classes ensures that the optimization provided by ConfigContextQuerySetMixin takes effect.
adam added the type: bugstatus: accepted labels 2025-12-29 18:35:22 +01:00
adam closed this issue 2025-12-29 18:35:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?