starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add list of virtual machines to the cluster detail page #4337

New Issue
Closed
opened 2025-12-29 18:34:55 +01:00 by adam · 7 comments
adam commented 2025-12-29 18:34:55 +01:00
Owner
Copy Link

Originally created by @furlongm on GitHub (Dec 8, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

  • Python version: 3.6
  • NetBox version: 2.9.10

Proposed Functionality

Adding the list of virtual machines in a given cluster to the cluster detail page, underneath the list of host devices. Also, adding an "add virtual machine" button to that table to quickly add virtual machines to a cluster (as with the "add devices" button on the devices table).

Use Case

Having the list of virtual machines on the cluster page saves having to click the link to the virtual machines page every time you want to see the virtual machines within a cluster. This is a very common operation for us and one of the top complaints of our users.

Database Changes

None

External Dependencies

None

Originally created by @furlongm on GitHub (Dec 8, 2020). Originally assigned to: @jeremystretch on GitHub. <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. This form is only for proposing specific new features or enhancements. If you have a general idea or question, please post to our mailing list instead of opening an issue: https://groups.google.com/g/netbox-discuss NOTE: Due to an excessive backlog of feature requests, we are not currently accepting any proposals which significantly extend NetBox's feature scope. Please describe the environment in which you are running NetBox. Be sure that you are running an unmodified instance of the latest stable release before submitting a bug report. --> ### Environment * Python version: 3.6 * NetBox version: 2.9.10 <!-- Describe in detail the new functionality you are proposing. Include any specific changes to work flows, data models, or the user interface. --> ### Proposed Functionality Adding the list of virtual machines in a given cluster to the cluster detail page, underneath the list of host devices. Also, adding an "add virtual machine" button to that table to quickly add virtual machines to a cluster (as with the "add devices" button on the devices table). <!-- Convey an example use case for your proposed feature. Write from the perspective of a NetBox user who would benefit from the proposed functionality and describe how. ---> ### Use Case Having the list of virtual machines on the cluster page saves having to click the link to the virtual machines page every time you want to see the virtual machines within a cluster. This is a very common operation for us and one of the top complaints of our users. <!-- Note any changes to the database schema necessary to support the new feature. For example, does the proposal require adding a new model or field? (Not all new features require database changes.) ---> ### Database Changes None <!-- List any new dependencies on external libraries or services that this new feature would introduce. For example, does the proposal require the installation of a new Python package? (Not all new features introduce new dependencies.) --> ### External Dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 18:34:55 +01:00
adam closed this issue 2025-12-29 18:34:55 +01:00
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 8, 2020):

Clusters can have two types of resources assigned to them: hosts and virtual machines. Currently, the cluster view shows only assigned hosts. We could also display virtual machines, however the pagination system can handle only one type of object. So, we would need to decide for which type of object we'd support pagination.

Typically what we do in that case is to show each type of child object in a separate tab. (You can see an example of this when viewing a prefix, which can have both child prefixes and IP addresses.) That seems like a reasonable approach in this case.

@jeremystretch commented on GitHub (Dec 8, 2020): Clusters can have two types of resources assigned to them: hosts and virtual machines. Currently, the cluster view shows only assigned hosts. We could also display virtual machines, however the pagination system can handle only one type of object. So, we would need to decide for which type of object we'd support pagination. Typically what we do in that case is to show each type of child object in a separate tab. (You can see an example of this when viewing a prefix, which can have both child prefixes and IP addresses.) That seems like a reasonable approach in this case.
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@furlongm commented on GitHub (Dec 9, 2020):

It doesn't look like the current device table has pagination?

@furlongm commented on GitHub (Dec 9, 2020): It doesn't look like the current device table has pagination?
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 9, 2020):

If not, it should. (All tables should.)

@jeremystretch commented on GitHub (Dec 9, 2020): If not, it should. (All tables should.)
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Jan 23, 2021):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale[bot] commented on GitHub (Jan 23, 2021): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@furlongm commented on GitHub (Jan 26, 2021):

I implemented devices and virtual machines in separate tabs, but have not opened a PR. This is because It does exactly the opposite of the intention of the feature request - which was to reduce the number of clicks required to view the cluster details. Also, the resulting cluster detail page ends up pretty empty so it ends up showing less details about the cluster than previously, which also seems to run counter to the intention of the cluster detail page.

@furlongm commented on GitHub (Jan 26, 2021): I implemented devices and virtual machines in separate tabs, but have not opened a PR. This is because It does exactly the opposite of the intention of the feature request - which was to reduce the number of clicks required to view the cluster details. Also, the resulting cluster detail page ends up pretty empty so it ends up showing _less_ details about the cluster than previously, which also seems to run counter to the intention of the cluster detail page.
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Mar 19, 2021):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@stale[bot] commented on GitHub (Mar 19, 2021): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 18:34:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 25, 2021):

Marking this as blocked by the v2.12 UI work (#5893).

@jeremystretch commented on GitHub (Mar 25, 2021): Marking this as blocked by the v2.12 UI work (#5893).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?