starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Bug in validate uniqueness of VM name #4318

New Issue
Closed
opened 2025-12-29 18:34:43 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:34:43 +01:00
Owner
Copy Link

Originally created by @xcdr on GitHub (Dec 1, 2020).

Environment

  • Python version: 3.8.6
  • NetBox version: 2.9.10

Cannot add VM without Tenant to different clusters.

Steps to Reproduce

  1. Add cluster A, B
  2. Add VM named "Example VM" to cluster A without Tenant
  3. Try to add VM named "Example VM" to cluster B without Tenant

Expected Behavior

VM should be added.

Observed Behavior

I see validation error: A virtual machine with this name already exists.

I see that validate_unique(self, exclude=None) in VirtualMachine model doesn't filter by cluster!

Originally created by @xcdr on GitHub (Dec 1, 2020). ### Environment * Python version: 3.8.6 * NetBox version: 2.9.10 Cannot add VM without Tenant to different clusters. ### Steps to Reproduce 1. Add cluster A, B 2. Add VM named "Example VM" to cluster A without Tenant 3. Try to add VM named "Example VM" to cluster B without Tenant ### Expected Behavior VM should be added. ### Observed Behavior I see validation error: A virtual machine with this name already exists. I see that `validate_unique(self, exclude=None)` in VirtualMachine model doesn't filter by cluster!
adam added the type: bugstatus: accepted labels 2025-12-29 18:34:43 +01:00
adam closed this issue 2025-12-29 18:34:43 +01:00
adam commented 2025-12-29 18:34:43 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 3, 2020):

The ability to have multiple VirtualMachine instances with duplicate names was introduced in #2669, however looking back it's not entirely clear what the constraints were intended to be. The current code looks like this:

def validate_unique(self, exclude=None):
    if self.tenant is None and VirtualMachine.objects.exclude(pk=self.pk).filter(
        name=self.name, tenant__isnull=True
    ):

This allows duplicate names only for VMs which do not have a tenant assigned, but makes no reference to Cluster. Meta.unique_together sets ['cluster', 'tenant', 'name'], which leads me to believe the intent was to constrain scope to individual cluster-tenant pairs.

We can "fix" this by extending validate_unique() to check against assigned cluster as well, which I think makes sense.

@jeremystretch commented on GitHub (Dec 3, 2020): The ability to have multiple VirtualMachine instances with duplicate names was introduced in #2669, however looking back it's not entirely clear what the constraints were intended to be. The current code looks like this: ```python def validate_unique(self, exclude=None): if self.tenant is None and VirtualMachine.objects.exclude(pk=self.pk).filter( name=self.name, tenant__isnull=True ): ``` This allows duplicate names only for VMs which do not have a tenant assigned, but makes no reference to Cluster. `Meta.unique_together` sets `['cluster', 'tenant', 'name']`, which leads me to believe the intent was to constrain scope to individual cluster-tenant pairs. We can "fix" this by extending `validate_unique()` to check against assigned cluster as well, which I think makes sense.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?