starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Error when adding/editing secrets with webhooks for secrets enabled #4304

New Issue
Closed
opened 2025-12-29 18:34:31 +01:00 by adam · 11 comments
adam commented 2025-12-29 18:34:31 +01:00
Owner
Copy Link

Originally created by @tyldum on GitHub (Nov 25, 2020).

Environment

  • Python version: 3.8.6
  • NetBox version: 2.9.9

Steps to Reproduce

  1. Enable a webhook on secrets
  2. Secret on a device
  3. Save

Expected Behavior

No errors, return to list of secrets

Observed Behavior

Got an error:

<class '_pickle.PicklingError'>

Can't pickle <function paginator_number at 0x7fcbf0afb670>: it's not the same object as django.contrib.admin.templatetags.admin_list.paginator_number

The secret is stored without the tag.
Tags can be added afterwards without further issues.

(in light of the proposal to move this functionality into a plugin, I realize it might quickly become obsolete)

Originally created by @tyldum on GitHub (Nov 25, 2020). <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. This form is only for reproducible bugs. If you need assistance with NetBox installation, or if you have a general question, DO NOT open an issue. Instead, post to our mailing list: https://groups.google.com/g/netbox-discuss Please describe the environment in which you are running NetBox. Be sure that you are running an unmodified instance of the latest stable release before submitting a bug report, and that any plugins have been disabled. --> ### Environment * Python version: 3.8.6 * NetBox version: 2.9.9 <!-- Describe in detail the exact steps that someone else can take to reproduce this bug using the current stable release of NetBox. Begin with the creation of any necessary database objects and call out every operation being performed explicitly. If reporting a bug in the REST API, be sure to reconstruct the raw HTTP request(s) being made: Don't rely on a client library such as pynetbox. --> ### Steps to Reproduce 1. Enable a webhook on `secrets` 1. Secret on a device 3. Save <!-- What did you expect to happen? --> ### Expected Behavior No errors, return to list of secrets <!-- What happened instead? --> ### Observed Behavior Got an error: ``` <class '_pickle.PicklingError'> Can't pickle <function paginator_number at 0x7fcbf0afb670>: it's not the same object as django.contrib.admin.templatetags.admin_list.paginator_number ``` The secret is stored without the tag. Tags can be added afterwards without further issues. (in light of the proposal to move this functionality into a plugin, I realize it might quickly become obsolete)
adam added the type: bug label 2025-12-29 18:34:31 +01:00
adam closed this issue 2025-12-29 18:34:32 +01:00
adam commented 2025-12-29 18:34:32 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 25, 2020):

I'm not able to reproduce this on v2.9.10: Secrets are created with tags as expected. Additionally, the exception being reported makes no sense. Have you modified your NetBox code base in any way? If not, please post the entire stack trace (enable debugging by setting DEBUG=True in configuration.py).

@jeremystretch commented on GitHub (Nov 25, 2020): I'm not able to reproduce this on v2.9.10: Secrets are created with tags as expected. Additionally, the exception being reported makes no sense. Have you modified your NetBox code base in any way? If not, please post the entire stack trace (enable debugging by setting `DEBUG=True` in `configuration.py`).
adam commented 2025-12-29 18:34:32 +01:00
Author
Owner
Copy Link

@tyldum commented on GitHub (Nov 26, 2020):

Running the stock docker image with -ldap. Upgraded to v2.9.10, same thing.

<class '_pickle.PicklingError'>

Can't pickle <function paginator_number at 0x7f6de3c74a60>: it's not the same object as django.contrib.admin.templatetags.admin_list.paginator_number

Python version: 3.8.6
NetBox version: 2.9.10

Stack trace:

Environment:


Request Method: POST
Request URL: http://xxxx/secrets/secrets/add/

Django Version: 3.1
Python Version: 3.8.6
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'django.contrib.humanize',
 'cacheops',
 'corsheaders',
 'debug_toolbar',
 'django_filters',
 'django_tables2',
 'django_prometheus',
 'mptt',
 'rest_framework',
 'taggit',
 'timezone_field',
 'circuits',
 'dcim',
 'ipam',
 'extras',
 'secrets',
 'tenancy',
 'users',
 'utilities',
 'virtualization',
 'django_rq',
 'drf_yasg']
Installed Middleware:
['debug_toolbar.middleware.DebugToolbarMiddleware',
 'django_prometheus.middleware.PrometheusBeforeMiddleware',
 'corsheaders.middleware.CorsMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'utilities.middleware.ExceptionHandlingMiddleware',
 'utilities.middleware.RemoteUserMiddleware',
 'utilities.middleware.LoginRequiredMiddleware',
 'utilities.middleware.APIVersionMiddleware',
 'extras.middleware.ObjectChangeMiddleware',
 'django_prometheus.middleware.PrometheusAfterMiddleware']



Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 179, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/views/generic/base.py", line 73, in view
    return self.dispatch(request, *args, **kwargs)
  File "/opt/netbox/netbox/secrets/views.py", line 97, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/opt/netbox/netbox/utilities/views.py", line 393, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/opt/netbox/netbox/utilities/views.py", line 124, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django/views/generic/base.py", line 101, in dispatch
    return handler(request, *args, **kwargs)
  File "/opt/netbox/netbox/secrets/views.py", line 128, in post
    secret.save()
  File "/usr/local/lib/python3.8/site-packages/django/db/models/base.py", line 750, in save
    self.save_base(using=using, force_insert=force_insert,
  File "/usr/local/lib/python3.8/site-packages/django/db/models/base.py", line 798, in save_base
    post_save.send(
  File "/usr/local/lib/python3.8/site-packages/django/dispatch/dispatcher.py", line 177, in send
    return [
  File "/usr/local/lib/python3.8/site-packages/django/dispatch/dispatcher.py", line 178, in <listcomp>
    (receiver, receiver(signal=self, sender=sender, **named))
  File "/opt/netbox/netbox/utilities/utils.py", line 283, in _curried
    return _curried_func(*args, *moreargs, **{**kwargs, **morekwargs})
  File "/opt/netbox/netbox/extras/signals.py", line 42, in _handle_changed_object
    enqueue_webhooks(instance, request.user, request.id, action)
  File "/opt/netbox/netbox/extras/webhooks.py", line 57, in enqueue_webhooks
    webhook_queue.enqueue(
  File "/usr/local/lib/python3.8/site-packages/rq/queue.py", line 418, in enqueue
    return self.enqueue_call(
  File "/usr/local/lib/python3.8/site-packages/django_rq/queues.py", line 68, in enqueue_call
    return self.original_enqueue_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/django_rq/queues.py", line 64, in original_enqueue_call
    return super(DjangoRQ, self).enqueue_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/rq/queue.py", line 365, in enqueue_call
    job = self.enqueue_job(job, at_front=at_front)
  File "/usr/local/lib/python3.8/site-packages/rq/queue.py", line 473, in enqueue_job
    job.save(pipeline=pipe)
  File "/usr/local/lib/python3.8/site-packages/rq/job.py", line 591, in save
    mapping = self.to_dict(include_meta=include_meta)
  File "/usr/local/lib/python3.8/site-packages/rq/job.py", line 537, in to_dict
    'data': zlib.compress(self.data),
  File "/usr/local/lib/python3.8/site-packages/rq/job.py", line 232, in data
    self._data = self.serializer.dumps(job_tuple)

Exception Type: PicklingError at /secrets/secrets/add/
Exception Value: Can't pickle <function paginator_number at 0x7f18bdc131f0>: it's not the same object as django.contrib.admin.templatetags.admin_list.paginator_number
@tyldum commented on GitHub (Nov 26, 2020): Running the stock docker image with `-ldap`. Upgraded to v2.9.10, same thing. ``` <class '_pickle.PicklingError'> Can't pickle <function paginator_number at 0x7f6de3c74a60>: it's not the same object as django.contrib.admin.templatetags.admin_list.paginator_number Python version: 3.8.6 NetBox version: 2.9.10 ``` Stack trace: ``` Environment: Request Method: POST Request URL: http://xxxx/secrets/secrets/add/ Django Version: 3.1 Python Version: 3.8.6 Installed Applications: ['django.contrib.admin', 'django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.sessions', 'django.contrib.messages', 'django.contrib.staticfiles', 'django.contrib.humanize', 'cacheops', 'corsheaders', 'debug_toolbar', 'django_filters', 'django_tables2', 'django_prometheus', 'mptt', 'rest_framework', 'taggit', 'timezone_field', 'circuits', 'dcim', 'ipam', 'extras', 'secrets', 'tenancy', 'users', 'utilities', 'virtualization', 'django_rq', 'drf_yasg'] Installed Middleware: ['debug_toolbar.middleware.DebugToolbarMiddleware', 'django_prometheus.middleware.PrometheusBeforeMiddleware', 'corsheaders.middleware.CorsMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.messages.middleware.MessageMiddleware', 'django.middleware.clickjacking.XFrameOptionsMiddleware', 'django.middleware.security.SecurityMiddleware', 'utilities.middleware.ExceptionHandlingMiddleware', 'utilities.middleware.RemoteUserMiddleware', 'utilities.middleware.LoginRequiredMiddleware', 'utilities.middleware.APIVersionMiddleware', 'extras.middleware.ObjectChangeMiddleware', 'django_prometheus.middleware.PrometheusAfterMiddleware'] Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner response = get_response(request) File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 179, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/local/lib/python3.8/site-packages/django/views/generic/base.py", line 73, in view return self.dispatch(request, *args, **kwargs) File "/opt/netbox/netbox/secrets/views.py", line 97, in dispatch return super().dispatch(request, *args, **kwargs) File "/opt/netbox/netbox/utilities/views.py", line 393, in dispatch return super().dispatch(request, *args, **kwargs) File "/opt/netbox/netbox/utilities/views.py", line 124, in dispatch return super().dispatch(request, *args, **kwargs) File "/usr/local/lib/python3.8/site-packages/django/views/generic/base.py", line 101, in dispatch return handler(request, *args, **kwargs) File "/opt/netbox/netbox/secrets/views.py", line 128, in post secret.save() File "/usr/local/lib/python3.8/site-packages/django/db/models/base.py", line 750, in save self.save_base(using=using, force_insert=force_insert, File "/usr/local/lib/python3.8/site-packages/django/db/models/base.py", line 798, in save_base post_save.send( File "/usr/local/lib/python3.8/site-packages/django/dispatch/dispatcher.py", line 177, in send return [ File "/usr/local/lib/python3.8/site-packages/django/dispatch/dispatcher.py", line 178, in <listcomp> (receiver, receiver(signal=self, sender=sender, **named)) File "/opt/netbox/netbox/utilities/utils.py", line 283, in _curried return _curried_func(*args, *moreargs, **{**kwargs, **morekwargs}) File "/opt/netbox/netbox/extras/signals.py", line 42, in _handle_changed_object enqueue_webhooks(instance, request.user, request.id, action) File "/opt/netbox/netbox/extras/webhooks.py", line 57, in enqueue_webhooks webhook_queue.enqueue( File "/usr/local/lib/python3.8/site-packages/rq/queue.py", line 418, in enqueue return self.enqueue_call( File "/usr/local/lib/python3.8/site-packages/django_rq/queues.py", line 68, in enqueue_call return self.original_enqueue_call(*args, **kwargs) File "/usr/local/lib/python3.8/site-packages/django_rq/queues.py", line 64, in original_enqueue_call return super(DjangoRQ, self).enqueue_call(*args, **kwargs) File "/usr/local/lib/python3.8/site-packages/rq/queue.py", line 365, in enqueue_call job = self.enqueue_job(job, at_front=at_front) File "/usr/local/lib/python3.8/site-packages/rq/queue.py", line 473, in enqueue_job job.save(pipeline=pipe) File "/usr/local/lib/python3.8/site-packages/rq/job.py", line 591, in save mapping = self.to_dict(include_meta=include_meta) File "/usr/local/lib/python3.8/site-packages/rq/job.py", line 537, in to_dict 'data': zlib.compress(self.data), File "/usr/local/lib/python3.8/site-packages/rq/job.py", line 232, in data self._data = self.serializer.dumps(job_tuple) Exception Type: PicklingError at /secrets/secrets/add/ Exception Value: Can't pickle <function paginator_number at 0x7f18bdc131f0>: it's not the same object as django.contrib.admin.templatetags.admin_list.paginator_number ```
adam commented 2025-12-29 18:34:32 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 30, 2020):

Running the stock docker image

Please note that all bug reports must be reproducible in an unmodified instance of the latest official release.

The stack trace you posted indicates a problem with a webhook you've created, which was not mentioned in your original report. Disabling or correcting the webhook will likely resolve this issue.

@jeremystretch commented on GitHub (Nov 30, 2020): > Running the stock docker image Please note that all bug reports must be reproducible in an unmodified instance of the latest official release. The stack trace you posted indicates a problem with a webhook you've created, which was not mentioned in your original report. Disabling or correcting the webhook will likely resolve this issue.
adam commented 2025-12-29 18:34:32 +01:00
Author
Owner
Copy Link

@tyldum commented on GitHub (Nov 30, 2020):

The webhook is valid and the error is triggered by creating or changing a secret with the webhook enabled. Deleting the secret works without errors and issues the webhook as expected.

The webhook is as simple as you can define it, no headers or body. Same webhook is used on several object types for audit alerts, without issues (and works on delete events on secrets).

I'll see if I can replicate on a virgin install. Updating title as it is misleading.

@tyldum commented on GitHub (Nov 30, 2020): The webhook is valid and the error is triggered by creating or changing a secret with the webhook enabled. Deleting the secret works without errors and issues the webhook as expected. The webhook is as simple as you can define it, no headers or body. Same webhook is used on several object types for audit alerts, without issues (and works on delete events on secrets). I'll see if I can replicate on a virgin install. Updating title as it is misleading.
adam commented 2025-12-29 18:34:32 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 3, 2020):

Well, I've gotten as far as reproducing this. It might take some time to unpack exactly what's going on, though.

@tyldum you've only seen this with secrets, correct? No other models?

@jeremystretch commented on GitHub (Dec 3, 2020): Well, I've gotten as far as reproducing this. It might take some time to unpack exactly what's going on, though. @tyldum you've only seen this with secrets, correct? No other models?
adam commented 2025-12-29 18:34:32 +01:00
Author
Owner
Copy Link

@tyldum commented on GitHub (Dec 3, 2020):

That is correct.
Reported mostly for consistency and correct behavior. We can live without it, if you decide the correct behavior is to remove webhooks on secrets.

@tyldum commented on GitHub (Dec 3, 2020): That is correct. Reported mostly for consistency and correct behavior. We can live without it, if you decide the correct behavior is to remove webhooks on secrets.
adam commented 2025-12-29 18:34:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 4, 2020):

No no, it should definitely work as-is. When you first reported that it was due to a webhook I figured it was due to some invalid template code, because the exception message didn't make any sense. And it still doesn't.

@jeremystretch commented on GitHub (Dec 4, 2020): No no, it should definitely work as-is. When you first reported that it was due to a webhook I figured it was due to some invalid template code, because the exception message didn't make any sense. And it still doesn't.
adam commented 2025-12-29 18:34:33 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Dec 4, 2020):

Have we tried to disable caching to see if it is a caching related issue?

@DanSheps commented on GitHub (Dec 4, 2020): Have we tried to disable caching to see if it is a caching related issue?
adam commented 2025-12-29 18:34:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 4, 2020):

Yeah, I've been testing it without caching enabled. Best I can tell it has something to do with the serializer for secrets, but I'm not sure what specifically is causing the exception.

I did come across this very similar-looking bug but it seems to have been something related to SQLite. Still need to dig into this more.

@jeremystretch commented on GitHub (Dec 4, 2020): Yeah, I've been testing it without caching enabled. Best I can tell it has something to do with the serializer for secrets, but I'm not sure what specifically is causing the exception. I did come across [this very similar-looking bug](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915626) but it seems to have been something related to SQLite. Still need to dig into this more.
adam commented 2025-12-29 18:34:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 4, 2020):

All I've been able to identify so far is that omitting the url field from SecretSerializer avoids triggering the PicklingError exception. Of course this makes no sense, because every model uses a HyperlinkedIdentityField in its serializer, and there are other instances of HyperlinkedIdentityField within nested serializers within SecretSerializer.

@jeremystretch commented on GitHub (Dec 4, 2020): All I've been able to identify so far is that omitting the `url` field from SecretSerializer avoids triggering the PicklingError exception. Of course this makes no sense, because every model uses a HyperlinkedIdentityField in its serializer, and there are other instances of HyperlinkedIdentityField within nested serializers within SecretSerializer.
adam commented 2025-12-29 18:34:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 4, 2021):

Closing this out as it will ultimately be addressed by #5278 in v2.12.

@jeremystretch commented on GitHub (May 4, 2021): Closing this out as it will ultimately be addressed by #5278 in v2.12.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4304
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?