Scripts executed in dry-run mode trigger webhooks #4251

New Issue

adam · 2025-12-29T18:34:14+01:00

adam commented

2025-12-29 18:34:14 +01:00

Originally created by @BarbarossaTM on GitHub (Nov 6, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

Python version: 3.7.9
NetBox version: 2.9.3

Steps to Reproduce

I wrote a script to deploy new POPs following a codified building plan, which worked great :)

Configure a webhook to trigger on create/update and call some remote URL
Run a script which creates/updates some items within netbox and execute the script in dry-run mode.

No changes to the DB will be written as the DB transaction will be rolled back but webhooks will be triggered.

Expected Behavior

No webhooks will be triggered on dry-run execution of scripts

Observed Behavior

Webhooks are executed for scripts in dry-run mode.

Originally created by @BarbarossaTM on GitHub (Nov 6, 2020). Originally assigned to: @jeremystretch on GitHub. ### Environment * Python version: 3.7.9 * NetBox version: 2.9.3 ### Steps to Reproduce I wrote a [script](https://blog.sdn.clinic/2020/06/deploying-a-pop-with-netbox-scripts/) to deploy new POPs following a codified building plan, which worked great :) 1. Configure a webhook to trigger on create/update and call some remote URL 2. Run a script which creates/updates some items within netbox and execute the script in dry-run mode. No changes to the DB will be written as the DB transaction will be rolled back but webhooks will be triggered. ### Expected Behavior No webhooks will be triggered on dry-run execution of scripts ### Observed Behavior Webhooks are executed for scripts in dry-run mode.

adam added the type: bug status: accepted labels 2025-12-29 18:34:14 +01:00

adam closed this issue

2025-12-29 18:34:14 +01:00

adam commented

2025-12-29 18:34:14 +01:00

@BarbarossaTM commented on GitHub (Nov 8, 2020):

Update:

I tried to update my script to only call .save() when commit is True which works at most places but seems to fail when querying interfaces/ports of devices created from a Device Type. I'm under the impression that those queries are done against the DB and not the model in RAM.

@BarbarossaTM commented on GitHub (Nov 8, 2020): Update: I tried to update my script to only call `.save()` when `commit` is `True` which works at most places but seems to fail when querying interfaces/ports of devices created from a Device Type. I'm under the impression that those queries are done against the DB and not the model in RAM.

adam commented

2025-12-29 18:34:15 +01:00

@jeremystretch commented on GitHub (Nov 9, 2020):

Fixing this probably entails modifying the run_script() function to invoke the change_logging context manager only when commit is true.

@jeremystretch commented on GitHub (Nov 9, 2020): Fixing this probably entails modifying the `run_script()` function to invoke the `change_logging` context manager only when `commit` is true.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#4251