Omit get() method from simplistic ObjectView subclasses #4240

New Issue

adam · 2025-12-29T18:34:11+01:00

adam commented

2025-12-29 18:34:11 +01:00

Originally created by @jeremystretch on GitHub (Nov 3, 2020).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

The ObjectView class provides a basic get() method which renders a template with the current object as its context. Some views still employ their own minimal get() method which duplicate this functionality unnecessarily. For example:

class CableView(ObjectView):
    queryset = Cable.objects.all()

    def get(self, request, pk):
        cable = get_object_or_404(self.queryset, pk=pk)
        return render(request, 'dcim/cable.html', {
            'cable': cable,
        })

The get() method above can be omitted and the template updated to reference instance rather than cable.

Justification

Removes unneeded code

Originally created by @jeremystretch on GitHub (Nov 3, 2020). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes The ObjectView class provides a basic `get()` method which renders a template with the current object as its context. Some views still employ their own minimal `get()` method which duplicate this functionality unnecessarily. For example: ```python class CableView(ObjectView): queryset = Cable.objects.all() def get(self, request, pk): cable = get_object_or_404(self.queryset, pk=pk) return render(request, 'dcim/cable.html', { 'cable': cable, }) ``` The `get()` method above can be omitted and the template updated to reference `instance` rather than `cable`. ### Justification Removes unneeded code

adam added the status: accepted type: housekeeping labels 2025-12-29 18:34:11 +01:00

adam closed this issue

2025-12-29 18:34:12 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#4240