starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

PluginMenuItem with permission is still clickable #4023

New Issue
Closed
opened 2025-12-29 18:32:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:32:39 +01:00
Owner
Copy Link

Originally created by @kuzmik on GitHub (Aug 24, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

  • Python version: 3.8.5
  • NetBox version: 2.9.1

Steps to Reproduce

  1. Install (or create) a plugin with a PluginMenuItem that has permissions set on it
  2. Make sure your current user doesn't have the permission that the menu item requires
  3. Click the "Plugins" drop down; the link will be grey but still have an href
  4. Click the greyed out menu item

Expected Behavior

I expected the link not to be clickable

Observed Behavior

Clicking the link directed me to the correct page. I've added the PermissionRequiredMixin to the view, and that handles it, but I assumed the greyed out link would not be clickable.

Not a huge deal since I included the mixin, but I am concerned that my readonly users will load up the page and file "why does this page say I don't have access" tickets.

Originally created by @kuzmik on GitHub (Aug 24, 2020). Originally assigned to: @jeremystretch on GitHub. <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. This form is only for reproducible bugs. If you need assistance with NetBox installation, or if you have a general question, DO NOT open an issue. Instead, post to our mailing list: https://groups.google.com/forum/#!forum/netbox-discuss Please describe the environment in which you are running NetBox. Be sure that you are running an unmodified instance of the latest stable release before submitting a bug report, and that any plugins have been disabled. --> ### Environment * Python version: 3.8.5 * NetBox version: 2.9.1 <!-- Describe in detail the exact steps that someone else can take to reproduce this bug using the current stable release of NetBox. Begin with the creation of any necessary database objects and call out every operation being performed explicitly. If reporting a bug in the REST API, be sure to reconstruct the raw HTTP request(s) being made: Don't rely on a client library such as pynetbox. --> ### Steps to Reproduce 1. Install (or create) a plugin with a `PluginMenuItem` that has permissions set on it 2. Make sure your current user doesn't have the permission that the menu item requires 2. Click the "Plugins" drop down; the link will be grey but still have an href 3. Click the greyed out menu item <!-- What did you expect to happen? --> ### Expected Behavior I expected the link not to be clickable <!-- What happened instead? --> ### Observed Behavior Clicking the link directed me to the correct page. I've added the `PermissionRequiredMixin` to the view, and that handles it, but I assumed the greyed out link would not be clickable. Not a huge deal since I included the mixin, but I am concerned that my readonly users will load up the page and file "why does this page say I don't have access" tickets.
adam added the type: bugstatus: accepted labels 2025-12-29 18:32:39 +01:00
adam closed this issue 2025-12-29 18:32:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4023
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?