Unable to set VM primary_ip4 or primary_ip6 via GUI #4016

New Issue

adam · 2025-12-29T18:32:37+01:00

adam commented

2025-12-29 18:32:37 +01:00

Originally created by @candlerb on GitHub (Aug 23, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

Python version: 3.6.9
NetBox version: 2.9.1

Steps to Reproduce

Create a VM with one interface and IPv4 and IPv6 addresses attached to that interface (as per #5037)
In the GUI, edit the VM
Select dropdowns for "primary_ip4" and "primary_ip6"

Expected Behavior

To be able to select the IPv4/IPv6 addresses as primary

Observed Behavior

(Note "dcim.Interface.None" is broken). Then when you click Save:

However the addresses clearly are assigned to this VM.

Relates to #4721

Originally created by @candlerb on GitHub (Aug 23, 2020). Originally assigned to: @jeremystretch on GitHub. ### Environment * Python version: 3.6.9 * NetBox version: 2.9.1 ### Steps to Reproduce 1. Create a VM with one interface and IPv4 and IPv6 addresses attached to that interface (as per #5037) 2. In the GUI, edit the VM 3. Select dropdowns for "primary_ip4" and "primary_ip6" ### Expected Behavior To be able to select the IPv4/IPv6 addresses as primary ### Observed Behavior ![image](https://user-images.githubusercontent.com/44789/90976561-13b75c80-e536-11ea-8d67-b2ecc26d1e93.png) (Note "dcim.Interface.None" is broken). Then when you click Save: ![image](https://user-images.githubusercontent.com/44789/90976573-2762c300-e536-11ea-934a-d0bada52418d.png) However the addresses clearly *are* assigned to this VM. Relates to #4721

adam added the type: bug status: accepted labels 2025-12-29 18:32:38 +01:00

adam closed this issue

2025-12-29 18:32:38 +01:00

adam commented

2025-12-29 18:32:38 +01:00

@candlerb commented on GitHub (Aug 24, 2020):

I'm not sure if this is the right fix, but based on what dcim.Interface is doing I changed it as follows and it seems to work:

--- netbox/virtualization/forms.py.orig	2020-08-24 10:14:19.897596228 +0000
+++ netbox/virtualization/forms.py	2020-08-24 10:33:21.664067592 +0000
@@ -333,7 +333,7 @@
                 if interface_ips:
                     ip_choices.append(
                         ('Interface IPs', [
-                            (ip.id, '{} ({})'.format(ip.address, ip.interface)) for ip in interface_ips
+                            (ip.id, '{} ({})'.format(ip.address, ip.assigned_object)) for ip in interface_ips
                         ])
                     )
                 # Collect NAT IPs
(venv) root@netbox:/opt/netbox# diff -u netbox/virtualization/models.py{.orig,}
--- netbox/virtualization/models.py.orig	2020-08-24 10:11:03.993217700 +0000
+++ netbox/virtualization/models.py	2020-08-24 10:31:30.311129430 +0000
@@ -335,9 +335,9 @@
         for field in ['primary_ip4', 'primary_ip6']:
             ip = getattr(self, field)
             if ip is not None:
-                if ip.interface in interfaces:
+                if ip.assigned_object in interfaces:
                     pass
-                elif self.primary_ip4.nat_inside is not None and self.primary_ip4.nat_inside.interface in interfaces:
+                elif self.primary_ip4.nat_inside is not None and self.primary_ip4.nat_inside.assigned_object in interfaces:
                     pass
                 else:
                     raise ValidationError({

This fixes #5037 as well.

@candlerb commented on GitHub (Aug 24, 2020): I'm not sure if this is the right fix, but based on what dcim.Interface is doing I changed it as follows and it seems to work: ``` --- netbox/virtualization/forms.py.orig 2020-08-24 10:14:19.897596228 +0000 +++ netbox/virtualization/forms.py 2020-08-24 10:33:21.664067592 +0000 @@ -333,7 +333,7 @@ if interface_ips: ip_choices.append( ('Interface IPs', [ - (ip.id, '{} ({})'.format(ip.address, ip.interface)) for ip in interface_ips + (ip.id, '{} ({})'.format(ip.address, ip.assigned_object)) for ip in interface_ips ]) ) # Collect NAT IPs (venv) root@netbox:/opt/netbox# diff -u netbox/virtualization/models.py{.orig,} --- netbox/virtualization/models.py.orig 2020-08-24 10:11:03.993217700 +0000 +++ netbox/virtualization/models.py 2020-08-24 10:31:30.311129430 +0000 @@ -335,9 +335,9 @@ for field in ['primary_ip4', 'primary_ip6']: ip = getattr(self, field) if ip is not None: - if ip.interface in interfaces: + if ip.assigned_object in interfaces: pass - elif self.primary_ip4.nat_inside is not None and self.primary_ip4.nat_inside.interface in interfaces: + elif self.primary_ip4.nat_inside is not None and self.primary_ip4.nat_inside.assigned_object in interfaces: pass else: raise ValidationError({ ``` This fixes #5037 as well.

adam referenced this issue

2025-12-29 22:23:19 +01:00

[PR #4017] [MERGED] Fixes #4016: Removed duplicate tenant field for cluster edit form #12733

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#4016