starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Inaccurate documentation - unique device names #4010

New Issue
Closed
opened 2025-12-29 18:32:36 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:32:36 +01:00
Owner
Copy Link

Originally created by @spasarok on GitHub (Aug 22, 2020).

2116b928b6/netbox/dcim/models/devices.py (L457)

"Device names are not required, however if one is set it must be unique."

This seems inaccurate. Reviewing the code, it looks like a validate_unique method exists but is never actually called. Is this intentional? If not I can make a pr to update the documentation if you'd like.

Originally created by @spasarok on GitHub (Aug 22, 2020). https://github.com/netbox-community/netbox/blob/2116b928b683d61c42ba12aeba5d44b18bc24417/netbox/dcim/models/devices.py#L457 "Device names are not required, however if one is set it must be unique." This seems inaccurate. Reviewing the code, it looks like a `validate_unique` method exists but is never actually called. Is this intentional? If not I can make a pr to update the documentation if you'd like.
adam closed this issue 2025-12-29 18:32:36 +01:00
adam commented 2025-12-29 18:32:36 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Aug 23, 2020):

This issue is pending closure as it does not conform to one of the provided templates as required by the contributing guide. If you'd like to request that your issue be re-opened, please first update the content so that it matches the appropriate template (this may require rewriting your issue entirely).

@DanSheps commented on GitHub (Aug 23, 2020): This issue is pending closure as it does not conform to one of the [provided templates](https://github.com/netbox-community/netbox/issues/new/choose) as required by the [contributing guide](https://github.com/netbox-community/netbox/blob/master/CONTRIBUTING.md). If you'd like to request that your issue be re-opened, please first update the content so that it matches the appropriate template (this may require rewriting your issue entirely).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4010
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?