starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Change ObjectPermission name to a required field #3935

New Issue
Closed
opened 2025-12-29 18:32:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:32:09 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Aug 3, 2020).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Make the name field on the ObjectPermission field mandatory. (Currently, it is optional.)

Justification

Experimentation with v2.9-beta1 has shown that a hard-coded name is necessary to effectively manage object-based permissions. Initially, the thought was that permissions would be conveyed as a tuple of model(s) and action(s), however that is unreliable and inefficient in practice. Requiring a static name results in object permissions being much easier to manage and more efficient to display. This also allows us to specify a native ordering for ObjectPermissions.

The 0009_replicate_permissions schema migration should be updated to copy over the <app>.<action>_<model> form of legacy permission names to their corresponding new ObjectPermission instances.

Originally created by @jeremystretch on GitHub (Aug 3, 2020). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Make the `name` field on the ObjectPermission field mandatory. (Currently, it is optional.) ### Justification Experimentation with v2.9-beta1 has shown that a hard-coded name is necessary to effectively manage object-based permissions. Initially, the thought was that permissions would be conveyed as a tuple of model(s) and action(s), however that is unreliable and inefficient in practice. Requiring a static name results in object permissions being much easier to manage and more efficient to display. This also allows us to specify a native ordering for ObjectPermissions. The `0009_replicate_permissions` schema migration should be updated to copy over the `<app>.<action>_<model>` form of legacy permission names to their corresponding new ObjectPermission instances.
adam added the status: acceptedtype: housekeepingbeta labels 2025-12-29 18:32:09 +01:00
adam closed this issue 2025-12-29 18:32:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?