starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Upgrade script should check for contents in local_requirements.txt before referencing it #3905

New Issue
Closed
opened 2025-12-29 18:31:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:31:54 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jul 27, 2020).

Proposed Changes

The upgrade script (upgrade.sh) should check for contents within local_requirements.txt before attempting to reference it with pip install.

Justification

Currently, if the upgrade script is run with an empty local_requirements.txt file, it produces the following output:

Installing local dependencies (pip3 install -r local_requirements.txt)...
You must give at least one requirement to install (see "pip help install")

Although the upgrade script completes without issue, the second line implies an error. Skipping this step when no local dependencies have been defined avoids potentially confusing the user.

Originally created by @jeremystretch on GitHub (Jul 27, 2020). ### Proposed Changes The upgrade script (`upgrade.sh`) should check for contents within `local_requirements.txt` before attempting to reference it with `pip install`. ### Justification Currently, if the upgrade script is run with an empty `local_requirements.txt` file, it produces the following output: ``` Installing local dependencies (pip3 install -r local_requirements.txt)... You must give at least one requirement to install (see "pip help install") ``` Although the upgrade script completes without issue, the second line implies an error. Skipping this step when no local dependencies have been defined avoids potentially confusing the user.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:31:54 +01:00
adam closed this issue 2025-12-29 18:31:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?