starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Transition TreeNodeChoiceFields to API-driven DynamicModelChoiceFields #3847

New Issue
Closed
opened 2025-12-29 18:31:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:31:35 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jul 8, 2020).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

NetBox currently uses two form fields provided by django-mptt, TreeNodeChoiceField and TreeNodeMultipleChoiceField, for representing relationships to MPTT-enabled (nested) models. (These models currently include regions, rack groups, and tenant groups.)

This issue proposes replacing these form fields with DynamicModelChoiceField and DynamicModelMultipleChoiceField, respectively, which populate options using the REST API. To accomplish this, we'll need to convey the MPTT depth of each item via its API representation; e.g. by adding a numeric depth field. This will allow us to accurately represent the nested relationship of each item in the form widget.

Justification

Most other object relationships now use API-driven form fields. For some reason, we never got around to making the transition for MPTT models.

Originally created by @jeremystretch on GitHub (Jul 8, 2020). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes NetBox currently uses two form fields provided by [django-mptt](https://github.com/django-mptt/django-mptt), TreeNodeChoiceField and TreeNodeMultipleChoiceField, for representing relationships to MPTT-enabled (nested) models. (These models currently include regions, rack groups, and tenant groups.) This issue proposes replacing these form fields with DynamicModelChoiceField and DynamicModelMultipleChoiceField, respectively, which populate options using the REST API. To accomplish this, we'll need to convey the MPTT depth of each item via its API representation; e.g. by adding a numeric `depth` field. This will allow us to accurately represent the nested relationship of each item in the form widget. ### Justification Most other object relationships now use API-driven form fields. For some reason, we never got around to making the transition for MPTT models.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:31:35 +01:00
adam closed this issue 2025-12-29 18:31:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3847
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?