starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[language] inclusivity #3835

New Issue
Closed
opened 2025-12-29 18:31:32 +01:00 by adam · 3 comments
adam commented 2025-12-29 18:31:32 +01:00
Owner
Copy Link

Originally created by @drewrothstein on GitHub (Jul 5, 2020).

Environment

  • Python version: all
  • NetBox version: all

Proposed Functionality

  • Changing all references of whitelist (env vars) to allowlist.
  • PR is trivial/ready once accepted.

Use Case

  • More inclusive language.

Database Changes

  • None.

External Dependencies

  • None.
Originally created by @drewrothstein on GitHub (Jul 5, 2020). ### Environment * Python version: `all` * NetBox version: `all` ### Proposed Functionality * Changing all references of `whitelist` (env vars) to `allowlist`. * PR is trivial/ready once accepted. ### Use Case * More inclusive language. ### Database Changes * None. ### External Dependencies * None.
adam closed this issue 2025-12-29 18:31:32 +01:00
adam commented 2025-12-29 18:31:32 +01:00
Author
Owner
Copy Link

@lampwins commented on GitHub (Jul 6, 2020):

The only occurrence of whitelist/blacklist in NetBox comes from settings defined by dango-cors-headers. We have no control over these settings. If you feel strongly about this, raise the issue upstream.

@lampwins commented on GitHub (Jul 6, 2020): The only occurrence of whitelist/blacklist in NetBox comes from settings defined by [dango-cors-headers](https://github.com/adamchainz/django-cors-headers). We have no control over these settings. If you feel strongly about this, raise the issue upstream.
adam commented 2025-12-29 18:31:32 +01:00
Author
Owner
Copy Link

@drewrothstein commented on GitHub (Jul 6, 2020):

Understood and thank you for the pointer - they have an open PR: https://github.com/adamchainz/django-cors-headers/pull/531.

@drewrothstein commented on GitHub (Jul 6, 2020): Understood and thank you for the pointer - they have an open PR: https://github.com/adamchainz/django-cors-headers/pull/531.
adam commented 2025-12-29 18:31:33 +01:00
Author
Owner
Copy Link

@drewrothstein commented on GitHub (Sep 21, 2020):

This is now merged and is available in 3.5.0.
Opened https://github.com/netbox-community/netbox/issues/5160 for discussion/review.
Happy to send over a PR for this trivial change.

Cheers-

@drewrothstein commented on GitHub (Sep 21, 2020): This is now merged and is available in `3.5.0`. Opened https://github.com/netbox-community/netbox/issues/5160 for discussion/review. Happy to send over a PR for this trivial change. Cheers-
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?