starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Server error when adding a duplicate secret #3738

New Issue
Closed
opened 2025-12-29 18:30:51 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:30:51 +01:00
Owner
Copy Link

Originally created by @nmereddi on GitHub (May 31, 2020).

Environment

  • Python version: 3.7
  • NetBox version: 2.8.4

Steps to Reproduce

  1. Create a secret, say S1 for a device D1, for a secret role R1
  2. Repeat step 1. Netbox throws a server error

Expected Behavior

Throw a validation error on the form rather a server error to be consistent with other features.

Observed Behavior

There was a problem with your request. Please contact an administrator.

<class 'django.db.utils.IntegrityError'>

duplicate key value violates unique constraint "secrets_secret_device_id_role_id_name_f8acc218_uniq"
DETAIL: Key (device_id, role_id, name)=(1, 1, S1) already exists.

Originally created by @nmereddi on GitHub (May 31, 2020). ### Environment * Python version: 3.7 * NetBox version: 2.8.4 ### Steps to Reproduce 1. Create a secret, say S1 for a device D1, for a secret role R1 2. Repeat step 1. Netbox throws a server error ### Expected Behavior Throw a validation error on the form rather a server error to be consistent with other features. ### Observed Behavior There was a problem with your request. Please contact an administrator. <class 'django.db.utils.IntegrityError'> duplicate key value violates unique constraint "secrets_secret_device_id_role_id_name_f8acc218_uniq" DETAIL: Key (device_id, role_id, name)=(1, 1, S1) already exists.
adam added the type: bugstatus: accepted labels 2025-12-29 18:30:51 +01:00
adam closed this issue 2025-12-29 18:30:51 +01:00
adam commented 2025-12-29 18:30:51 +01:00
Author
Owner
Copy Link

@itdependsnetworks commented on GitHub (May 31, 2020):

I'm just a passerby, so my thoughts do not carry too much weight. However, I believe you are conflating form validation (via schema) and database integrity. Forms can relatively easily ensure that you meet a validation check such as email address, character length etc with javascript. For this, a SQL query would need to be made, which is actually a lot more complex (not just a little).

IMHO, this would add little value but incur a lot of technical debt and error prone.

@itdependsnetworks commented on GitHub (May 31, 2020): I'm just a passerby, so my thoughts do not carry too much weight. However, I believe you are conflating form validation (via schema) and database integrity. Forms can relatively easily ensure that you meet a validation check such as email address, character length etc with javascript. For this, a SQL query would need to be made, which is actually a lot more complex (not just a little). IMHO, this would add little value but incur a lot of technical debt and error prone.
adam commented 2025-12-29 18:30:51 +01:00
Author
Owner
Copy Link

@itdependsnetworks commented on GitHub (Jun 1, 2020):

I stand corrected :)

@itdependsnetworks commented on GitHub (Jun 1, 2020): I stand corrected :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?