Proxy support for webhooks #3579

New Issue

adam · 2025-12-29T18:29:59+01:00

adam commented

2025-12-29 18:29:59 +01:00

Originally created by @benjy44 on GitHub (Apr 16, 2020).

Originally assigned to: @jeremystretch on GitHub.

Environment

Python version: 3.6.5
NetBox version: 2.8.0

Proposed Functionality

It would be nice to be able to set a proxy server for the webhooks in the admin panel or in configuration.py

Use Case

The majority of the companies are behind a corporate proxy and when sending wehbooks requests to slack for example it would be convenient to be able to set a proxy server.
At the moment in my case, I have to manually modify extras/webhooks_worker.py to be able to post notifications to slack.

Database Changes

None

External Dependencies

None

Originally created by @benjy44 on GitHub (Apr 16, 2020). Originally assigned to: @jeremystretch on GitHub.  ### Environment * Python version: 3.6.5 * NetBox version: 2.8.0  ### Proposed Functionality It would be nice to be able to set a proxy server for the webhooks in the admin panel or in configuration.py  ### Use Case The majority of the companies are behind a corporate proxy and when sending wehbooks requests to slack for example it would be convenient to be able to set a proxy server. At the moment in my case, I have to manually modify extras/webhooks_worker.py to be able to post notifications to slack.  ### Database Changes None  ### External Dependencies None

adam added the status: accepted type: feature labels 2025-12-29 18:29:59 +01:00

adam closed this issue

2025-12-29 18:29:59 +01:00

adam commented

2025-12-29 18:29:59 +01:00

@kobayashi commented on GitHub (Apr 19, 2020):

I think we can set this by add proxy field in webhook model or add to configuration.py.

configration.py might be flexible, i think.

WEBHOOK_PROXIES = {
  'http': 'http://192.168.1.10:3128',
  'https': 'http://192.168.2.10:1080',
}

Then set this as proxies attribute to session in webhook_worker.py.

Any idea?

@kobayashi commented on GitHub (Apr 19, 2020): I think we can set this by add `proxy` field in webhook model or add to configuration.py. configration.py might be flexible, i think. ``` WEBHOOK_PROXIES = { 'http': 'http://192.168.1.10:3128', 'https': 'http://192.168.2.10:1080', } ``` Then set this as `proxies` attribute to session in `webhook_worker.py`. Any idea?

adam commented

2025-12-29 18:29:59 +01:00

@molusk commented on GitHub (Apr 20, 2020):

We did the same modification to webhook_worker.py, it works like a charm !

# We need to use proxy to send webhooks
response = session.send(prepared_request, proxies={'https': 'http://proxy.example.org:8080'})
#response = session.send(prepared_request)

But it would be nice to allow also new version checks to pass through a proxy (the same in our case). We didn't find how to do it, yet.

@molusk commented on GitHub (Apr 20, 2020): We did the same modification to `webhook_worker.py`, it works like a charm ! ``` # We need to use proxy to send webhooks response = session.send(prepared_request, proxies={'https': 'http://proxy.example.org:8080'}) #response = session.send(prepared_request) ``` But it would be nice to allow also new version checks to pass through a proxy (the same in our case). We didn't find how to do it, yet.

adam commented

2025-12-29 18:29:59 +01:00

@jeremystretch commented on GitHub (Apr 20, 2020):

IMO it makes more sense to establish a configuration option to be used for all outbound HTTP connections, rather than defining a proxy individually per webhook.

@jeremystretch commented on GitHub (Apr 20, 2020): IMO it makes more sense to establish a configuration option to be used for all outbound HTTP connections, rather than defining a proxy individually per webhook.

adam referenced this issue

2025-12-29 19:30:40 +01:00

Improve hot-reloading of custom scripts #5648

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#3579