starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Fix the DeviceType filtering example in Custom Scripts #3558

New Issue
Closed
opened 2025-12-29 18:29:52 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:29:52 +01:00
Owner
Copy Link

Originally created by @markkuleinio on GitHub (Apr 10, 2020).

Change Type

[ ] Addition
[X] Correction
[ ] Deprecation
[ ] Cleanup (formatting, typos, etc.)

Area

[ ] Installation instructions
[ ] Configuration parameters
[X] Functionality/features
[ ] REST API
[ ] Administration/development
[ ] Other

Proposed Changes

The object filtering example does not work in Custom Scripts (the device list stays empty even though the device models exist in NetBox, tested with NetBox 2.7.11):

    switch_model = ObjectVar(
        description="Access switch model",
        queryset = DeviceType.objects.filter(
            manufacturer__name='Cisco',
            model__in=['Catalyst 3560X-48T', 'Catalyst 3750X-48T']
        )
    )

I propose updating the example with a working code.

In #4453 there is a mention about APISelect but I cannot figure out the correct filtering use of it to submit a PR on this.

Originally created by @markkuleinio on GitHub (Apr 10, 2020). <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. Please indicate the nature of the change by placing an X in one of the boxes below. --> ### Change Type [ ] Addition [X] Correction [ ] Deprecation [ ] Cleanup (formatting, typos, etc.) ### Area [ ] Installation instructions [ ] Configuration parameters [X] Functionality/features [ ] REST API [ ] Administration/development [ ] Other <!-- Describe the proposed change(s). --> ### Proposed Changes The object filtering example does not work in [Custom Scripts](https://netbox.readthedocs.io/en/stable/additional-features/custom-scripts/) (the device list stays empty even though the device models exist in NetBox, tested with NetBox 2.7.11): ``` switch_model = ObjectVar( description="Access switch model", queryset = DeviceType.objects.filter( manufacturer__name='Cisco', model__in=['Catalyst 3560X-48T', 'Catalyst 3750X-48T'] ) ) ``` I propose updating the example with a working code. In #4453 there is a mention about `APISelect` but I cannot figure out the correct filtering use of it to submit a PR on this.
adam added the status: duplicate label 2025-12-29 18:29:52 +01:00
adam closed this issue 2025-12-29 18:29:52 +01:00
adam commented 2025-12-29 18:29:52 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 10, 2020):

This looks to be essentially the same issue reported under #4463, and should be resolved by the same work. Going to mark it as a duplicate.

@jeremystretch commented on GitHub (Apr 10, 2020): This looks to be essentially the same issue reported under #4463, and should be resolved by the same work. Going to mark it as a duplicate.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3558
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?