starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Webhooks Failing #3542

New Issue
Closed
opened 2025-12-29 18:29:47 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:29:47 +01:00
Owner
Copy Link

Originally created by @robduffy2010 on GitHub (Apr 6, 2020).

Environment

  • Python version: 3.6.10
  • NetBox version: 2.7.11

Steps to Reproduce

  1. Create a webhook without any custom body or headers
  2. Edit device (I've only tested with devices but may also happen with other objects)
  3. Observe webhook failing

Expected Behavior

Webhook will succeed.

Observed Behavior

Webhooks fail and raise the following exception.

Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/rq/worker.py", line 884, in perform_job
rv = job.perform()
File "/usr/local/lib/python3.6/dist-packages/rq/job.py", line 664, in perform
self._result = self._execute()
File "/usr/local/lib/python3.6/dist-packages/rq/job.py", line 670, in _execute
return self.func(*self.args, **self.kwargs)
File "/opt/netbox/netbox/extras/webhooks_worker.py", line 32, in process_webhook
headers.update(webhook.render_headers(context))
AttributeError: 'Webhook' object has no attribute 'render_headers'

Originally created by @robduffy2010 on GitHub (Apr 6, 2020). ### Environment * Python version: 3.6.10 * NetBox version: 2.7.11 ### Steps to Reproduce 1. Create a webhook without any custom body or headers 2. Edit device (I've only tested with devices but may also happen with other objects) 3. Observe webhook failing ### Expected Behavior Webhook will succeed. ### Observed Behavior Webhooks fail and raise the following exception. Traceback (most recent call last): File "/usr/local/lib/python3.6/dist-packages/rq/worker.py", line 884, in perform_job rv = job.perform() File "/usr/local/lib/python3.6/dist-packages/rq/job.py", line 664, in perform self._result = self._execute() File "/usr/local/lib/python3.6/dist-packages/rq/job.py", line 670, in _execute return self.func(*self.args, **self.kwargs) File "/opt/netbox/netbox/extras/webhooks_worker.py", line 32, in process_webhook headers.update(webhook.render_headers(context)) AttributeError: 'Webhook' object has no attribute 'render_headers'
adam closed this issue 2025-12-29 18:29:47 +01:00
adam commented 2025-12-29 18:29:47 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 6, 2020):

Unable to replicate this on v2.7.11. Ensure that you've restarted the rqworker process since the last upgrade. If you need further assistance, please post to the mailing list.

@jeremystretch commented on GitHub (Apr 6, 2020): Unable to replicate this on v2.7.11. Ensure that you've restarted the rqworker process since the last upgrade. If you need further assistance, please post to the [mailing list](https://groups.google.com/forum/#!forum/netbox-discuss).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?