starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Duplicate device name, different site triggers uniqueness error #3512

New Issue
Closed
opened 2025-12-29 18:29:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:29:35 +01:00
Owner
Copy Link

Originally created by @DanSheps on GitHub (Mar 27, 2020).

Environment

  • Python version: 3.6
  • NetBox version: 2.7.10

Steps to Reproduce

  1. Create two sites S1 & S2
  2. Create a device, D1 in site S1
  3. Create a device D1 in site S2

Expected Behavior

Create D1 in S2 successfully

Observed Behavior

Validation Error: "A device with this name already exists"

Reason

In validate_unique() on the device model, we are suppose to be looking for a device assigned to the same site with no tenant. However, we are not setting the site and instead only looking for a duplicate name.

Fix

1393 -            if Device.objects.exclude(pk=self.pk).filter(name=self.name, tenant__isnull=True):
1393 +            if Device.objects.exclude(pk=self.pk).filter(name=self.name, site=self.site, tenant__isnull=True):
Originally created by @DanSheps on GitHub (Mar 27, 2020). ### Environment * Python version: 3.6 * NetBox version: 2.7.10 ### Steps to Reproduce 1. Create two sites S1 & S2 2. Create a device, D1 in site S1 3. Create a device D1 in site S2 ### Expected Behavior Create D1 in S2 successfully ### Observed Behavior Validation Error: "A device with this name already exists" ### Reason In validate_unique() on the device model, we are suppose to be looking for a device assigned to the same site with no tenant. However, we are not setting the site and instead only looking for a duplicate name. ### Fix ``` 1393 - if Device.objects.exclude(pk=self.pk).filter(name=self.name, tenant__isnull=True): 1393 + if Device.objects.exclude(pk=self.pk).filter(name=self.name, site=self.site, tenant__isnull=True):
adam added the type: bugstatus: accepted labels 2025-12-29 18:29:35 +01:00
adam closed this issue 2025-12-29 18:29:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3512
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?