starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove all id__in filters #3438

New Issue
Closed
opened 2025-12-29 18:29:07 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:29:07 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Mar 4, 2020).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Many models within NetBox have a filter named id__in which enables filtering by comma-separated object IDs, e.g. ?id__in=1,2,3. This was introduced in #987 to accommodate form widget filtering logic that is no longer used in NetBox. This issue proposes to remove all instance of id__in filters as well as the NumericInFilter class (which has no other uses).

Justification

This method of filtering is no longer needed, and the same result can be achieved using the more standard approach of passing the id parameter multiple times: ?id=1&id=2&id=3

Originally created by @jeremystretch on GitHub (Mar 4, 2020). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Many models within NetBox have a filter named `id__in` which enables filtering by comma-separated object IDs, e.g. `?id__in=1,2,3`. This was introduced in #987 to accommodate form widget filtering logic that is no longer used in NetBox. This issue proposes to remove all instance of `id__in` filters as well as the NumericInFilter class (which has no other uses). ### Justification This method of filtering is no longer needed, and the same result can be achieved using the more standard approach of passing the `id` parameter multiple times: `?id=1&id=2&id=3`
adam added the status: acceptedtype: deprecation labels 2025-12-29 18:29:07 +01:00
adam closed this issue 2025-12-29 18:29:07 +01:00
adam commented 2025-12-29 18:29:08 +01:00
Author
Owner
Copy Link

@loa commented on GitHub (May 6, 2020):

Hey @jeremystretch !

I wonder, this seem to have removed the only way of batch fetching multiple ipam resources?

@loa commented on GitHub (May 6, 2020): Hey @jeremystretch ! I wonder, this seem to have removed the only way of batch fetching multiple ipam resources?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: deprecation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?