starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Explore using API serializer for ObjectChange representation #3404

New Issue
Closed
opened 2025-12-29 18:28:47 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:28:47 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 25, 2020).

Proposed Changes

Explore the benefits and drawbacks of replacing the current ObjectChange serialization mechanism with the REST API serializers. I haven't dug into this yet but believe it's worth a look.

Justification

Consolidating serializers would allow us to ditch some code while ensuring a consistent representation of serialized objects throughout NetBox.

Originally created by @jeremystretch on GitHub (Feb 25, 2020). ### Proposed Changes Explore the benefits and drawbacks of replacing the current ObjectChange serialization mechanism with the REST API serializers. I haven't dug into this yet but believe it's worth a look. ### Justification Consolidating serializers would allow us to ditch some code while ensuring a consistent representation of serialized objects throughout NetBox.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:28:47 +01:00
adam closed this issue 2025-12-29 18:28:47 +01:00
adam commented 2025-12-29 18:28:47 +01:00
Author
Owner
Copy Link

@sdktr commented on GitHub (Mar 4, 2020):

Ditching duplicate (functionality wise) code, +1

@sdktr commented on GitHub (Mar 4, 2020): Ditching duplicate (functionality wise) code, +1
adam commented 2025-12-29 18:28:48 +01:00
Author
Owner
Copy Link

@ebusto commented on GitHub (Mar 10, 2020):

I took this approach in the NetBox Kafka producer plugin, and it works like a charm. Having slightly more information in place of foreign keys is really handy.

@ebusto commented on GitHub (Mar 10, 2020): I took this approach in the NetBox Kafka producer [plugin](https://github.com/ebusto/netbox-kafka-producer/blob/master/netbox_kafka_producer/middleware.py#L17), and it works like a charm. Having slightly more information in place of foreign keys is really handy.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3404
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?