starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add supported python version #3371

New Issue
Closed
opened 2025-12-29 18:28:28 +01:00 by adam · 4 comments
adam commented 2025-12-29 18:28:28 +01:00
Owner
Copy Link

Originally created by @kobayashi on GitHub (Feb 21, 2020).

Originally assigned to: @kobayashi on GitHub.

Change Type

[x] Addition
[ ] Correction
[ ] Deprecation
[ ] Cleanup (formatting, typos, etc.)

Area

[x] Installation instructions
[ ] Configuration parameters
[ ] Functionality/features
[ ] REST API
[ ] Administration/development
[ ] Other

Proposed Changes

There are no description which python versions are currently supported. Worth add the list of python version in the docs or README. I think Install Python Packges in the docs the place to add the list

Originally created by @kobayashi on GitHub (Feb 21, 2020). Originally assigned to: @kobayashi on GitHub. <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. Please indicate the nature of the change by placing an X in one of the boxes below. --> ### Change Type [x] Addition [ ] Correction [ ] Deprecation [ ] Cleanup (formatting, typos, etc.) ### Area [x] Installation instructions [ ] Configuration parameters [ ] Functionality/features [ ] REST API [ ] Administration/development [ ] Other <!-- Describe the proposed change(s). --> ### Proposed Changes There are no description which python versions are currently supported. Worth add the list of python version in the docs or README. I think [Install Python Packges](https://netbox.readthedocs.io/en/mkdocs-testing/installation/2-netbox/#install-python-packages) in the docs the place to add the list
adam added the status: acceptedtype: documentation labels 2025-12-29 18:28:28 +01:00
adam closed this issue 2025-12-29 18:28:28 +01:00
adam commented 2025-12-29 18:28:28 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 21, 2020):

We should also consider testing. We currently test against only the minimum supported Python version (which will change to 3.6 with NetBox v2.8). We can test against multiple versions but is it going to be worth the overhead to tests on every push/merge?

@jeremystretch commented on GitHub (Feb 21, 2020): We should also consider testing. We currently test against only the minimum supported Python version (which will change to 3.6 with NetBox v2.8). We can [test against multiple versions](https://docs.travis-ci.com/user/languages/python/#specifying-python-versions) but is it going to be worth the overhead to tests on every push/merge?
adam commented 2025-12-29 18:28:29 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Feb 21, 2020):

I haven't looked too much into travis, but is it possible to perform certain tests only on master/develop and not each PR?

I think testing every supported version on a merge to develop would still be wise, but perhaps not on every PR.

@DanSheps commented on GitHub (Feb 21, 2020): I haven't looked too much into travis, but is it possible to perform certain tests only on master/develop and not each PR? I think testing every supported version on a merge to develop would still be wise, but perhaps not on every PR.
adam commented 2025-12-29 18:28:29 +01:00
Author
Owner
Copy Link

@lampwins commented on GitHub (Feb 21, 2020):

We can test against multiple versions but is it going to be worth the overhead to tests on every push/merge?

I vote yes. It really doesn't cost us anything other than maybe having to wait an extra minute or two every once in a while. I don't see this as reason not to test, as it will begin to identify issues like #4220.

@lampwins commented on GitHub (Feb 21, 2020): > We can test against multiple versions but is it going to be worth the overhead to tests on every push/merge? I vote yes. It really doesn't cost us anything other than maybe having to wait an extra minute or two every once in a while. I don't see this as reason _not_ to test, as it will begin to identify issues like #4220.
adam commented 2025-12-29 18:28:29 +01:00
Author
Owner
Copy Link

@kobayashi commented on GitHub (Feb 24, 2020):

The place to add the description about supported version is better under Application Stack like this.

image

Also, I supports @lampwins's idea, so simply would add python version to the current travis.yml for testing.

python:
  - "3.5"
  - "3.6"
  - "3.7"

Any thoughts?

@kobayashi commented on GitHub (Feb 24, 2020): The place to add the description about supported version is better under [Application Stack](https://netbox.readthedocs.io/en/stable/#application-stack) like this. ![image](https://user-images.githubusercontent.com/8712070/75159960-34b60680-56e7-11ea-8339-37bf28129997.png) Also, I supports @lampwins's idea, so simply would add python version to the current travis.yml for testing. ``` python: - "3.5" - "3.6" - "3.7" ``` Any thoughts?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?