starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

utilities/api.py uses the wrong comparison operator in a few cases #3361

New Issue
Closed
opened 2025-12-29 18:28:18 +01:00 by adam · 3 comments
adam commented 2025-12-29 18:28:18 +01:00
Owner
Copy Link

Originally created by @ebusto on GitHub (Feb 21, 2020).

Environment

  • Python version: 3.8
  • NetBox version: 2.7.7

Steps to Reproduce

Start NetBox with Python 3.8 or newer.

Expected Behavior

No warnings.

Observed Behavior

Python emits the following warnings.

/opt/netbox/netbox/utilities/api.py:94: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if obj is '':
/opt/netbox/netbox/utilities/api.py:109: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if data is '':
Originally created by @ebusto on GitHub (Feb 21, 2020). # Environment * Python version: 3.8 * NetBox version: 2.7.7 ### Steps to Reproduce Start NetBox with Python 3.8 or newer. ### Expected Behavior No warnings. ### Observed Behavior Python emits the following warnings. ``` /opt/netbox/netbox/utilities/api.py:94: SyntaxWarning: "is" with a literal. Did you mean "=="? if obj is '': /opt/netbox/netbox/utilities/api.py:109: SyntaxWarning: "is" with a literal. Did you mean "=="? if data is '': ```
adam closed this issue 2025-12-29 18:28:18 +01:00
adam commented 2025-12-29 18:28:20 +01:00
Author
Owner
Copy Link

@kobayashi commented on GitHub (Feb 21, 2020):

Thank you for submitting your issue. NetBox does not support python 3.8 right now. Please try version 3.5 or 3.6 for now.

@kobayashi commented on GitHub (Feb 21, 2020): Thank you for submitting your issue. NetBox does not support python 3.8 right now. Please try version 3.5 or 3.6 for now.
adam commented 2025-12-29 18:28:21 +01:00
Author
Owner
Copy Link

@ebusto commented on GitHub (Feb 21, 2020):

This isn't an incompatibility. Rather, Python 3.8 is informing the developer that they used the wrong operator. This is a trivial fix, so why not do the right thing?

@ebusto commented on GitHub (Feb 21, 2020): This isn't an incompatibility. Rather, Python 3.8 is informing the developer that they used the wrong operator. This is a trivial fix, so why not do the right thing?
adam commented 2025-12-29 18:28:21 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 21, 2020):

Official support for Python 3.8 is being discussed elsewhere (see #4229), but aside from that I don't think we need bug reports for warning messages. They will be identified and addressed as needed through the course of development.

@jeremystretch commented on GitHub (Feb 21, 2020): Official support for Python 3.8 is being discussed elsewhere (see #4229), but aside from that I don't think we need bug reports for warning messages. They will be identified and addressed as needed through the course of development.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?