starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

If multiple RD value with separator will be set in VRF, we can get unusable situation for parse result and automation #3334

New Issue
Closed
opened 2025-12-29 18:27:52 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:27:52 +01:00
Owner
Copy Link

Originally created by @pnpwin on GitHub (Feb 16, 2020).

Environment

  • Python version: 3.7.6
  • NetBox version: 2.7.6

Hi. Because you use in 151943bfbc/netbox/ipam/models.py (L46) model CharField - we can get unusable situations like this:
telegram-cloud-photo-size-2-5354915051301088467-y

If multiple RD value with separator will be in this field, we can get unusable situation for parse result and automation.

Maybe you can use model for RD field and try to check-on-save value with this description https://tools.ietf.org/html/rfc4364#page-14 ?

Steps to Reproduce

  1. Open or create VRF;
  2. Set multiple RD value with separator;
  3. Save.

Expected Behavior

Observed Behavior

Originally created by @pnpwin on GitHub (Feb 16, 2020). <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. This form is only for reproducible bugs. If you need assistance with NetBox installation, or if you have a general question, DO NOT open an issue. Instead, post to our mailing list: https://groups.google.com/forum/#!forum/netbox-discuss Please describe the environment in which you are running NetBox. Be sure that you are running an unmodified instance of the latest stable release before submitting a bug report. --> ### Environment * Python version: 3.7.6 * NetBox version: 2.7.6 Hi. Because you use in https://github.com/netbox-community/netbox/blob/151943bfbc8e0d2b2a5055dc5ab03d7c1ea6847d/netbox/ipam/models.py#L46 model CharField - we can get unusable situations like this: ![telegram-cloud-photo-size-2-5354915051301088467-y](https://user-images.githubusercontent.com/25432591/74610866-0ee99a00-5108-11ea-8741-78003980bba9.jpg) If multiple RD value with separator will be in this field, we can get unusable situation for parse result and automation. Maybe you can use model for RD field and try to check-on-save value with this description https://tools.ietf.org/html/rfc4364#page-14 ? ### Steps to Reproduce 1. Open or create VRF; 2. Set multiple RD value with separator; 3. Save. <!-- What did you expect to happen? --> ### Expected Behavior <!-- What happened instead? --> ### Observed Behavior
adam closed this issue 2025-12-29 18:27:52 +01:00
adam commented 2025-12-29 18:27:53 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Feb 16, 2020):

The route distinguisher field is a free-form field. I don't believe we do any validation on the RD field, as this is more of a end user thing.

If you would like to have a FR for some more validation around the field, please request a re-open with a use case around the change and what database changes may be required.

@DanSheps commented on GitHub (Feb 16, 2020): The route distinguisher field is a free-form field. I don't believe we do any validation on the RD field, as this is more of a end user thing. If you would like to have a FR for some more validation around the field, please request a re-open with a use case around the change and what database changes may be required.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3334
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?