starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Allow filtering by Parent device in Interfaces view #3282

New Issue
Closed
opened 2025-12-29 18:27:24 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:27:24 +01:00
Owner
Copy Link

Originally created by @xtprox on GitHub (Feb 6, 2020).

Originally assigned to: @hSaria on GitHub.

Environment

  • Python version: 3.6.9
  • NetBox version: 2.7.4

Proposed Functionality

Allow interfaces to be filtered also by Parent device. Field should allow to select multiple devices.

Use Case

We're using tags to mark free/reserved/special interfaces to be able later select them and count/review. Now Netbox displaying all interfaces from all devices that matching criteria such as Name/Region/Site/Tags. Ability to filter by Parent device will help alot to find interfaces with selected tags on one/multiple devices.

Originally created by @xtprox on GitHub (Feb 6, 2020). Originally assigned to: @hSaria on GitHub. ### Environment * Python version: 3.6.9 * NetBox version: 2.7.4 ### Proposed Functionality Allow interfaces to be filtered also by Parent device. Field should allow to select multiple devices. ### Use Case We're using tags to mark free/reserved/special interfaces to be able later select them and count/review. Now Netbox displaying all interfaces from all devices that matching criteria such as Name/Region/Site/Tags. Ability to filter by Parent device will help alot to find interfaces with selected tags on one/multiple devices.
adam added the status: acceptedtype: feature labels 2025-12-29 18:27:24 +01:00
adam closed this issue 2025-12-29 18:27:24 +01:00
adam commented 2025-12-29 18:27:24 +01:00
Author
Owner
Copy Link

@hSaria commented on GitHub (Feb 6, 2020):

Fairly simple. This is somewhat similar to #3122. If there are no objections, I'd like to work on this (I've missed adding filter_for on the site field for device_id, so I'd improve that in the process).

Edit: or just git apply this:

diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py
index 34f18f6d..e9169523 100644
--- a/netbox/dcim/forms.py
+++ b/netbox/dcim/forms.py
@@ -84,7 +84,18 @@ class DeviceComponentFilterForm(BootstrapMixin, forms.Form):
         to_field_name='slug',
         widget=APISelectMultiple(
             api_url="/api/dcim/sites/",
-            value_field="slug"
+            value_field="slug",
+            filter_for={
+                'device_id': 'site',
+            }
+        )
+    )
+    device_id = FilterChoiceField(
+        queryset=Device.objects.all(),
+        required=False,
+        label='Device',
+        widget=APISelectMultiple(
+            api_url='/api/dcim/devices/',
         )
     )
 
@@ -3642,6 +3653,7 @@ class CableFilterForm(BootstrapMixin, forms.Form):
             value_field="slug",
             filter_for={
                 'rack_id': 'site',
+                'device_id': 'site',
             }
         )
     )
@@ -3663,6 +3675,9 @@ class CableFilterForm(BootstrapMixin, forms.Form):
         widget=APISelectMultiple(
             api_url="/api/dcim/racks/",
             null_option=True,
+            filter_for={
+                'device_id': 'rack_id',
+            }
         )
     )
     type = forms.MultipleChoiceField(
@@ -3816,6 +3831,9 @@ class ConsoleConnectionFilterForm(BootstrapMixin, forms.Form):
         widget=APISelectMultiple(
             api_url="/api/dcim/sites/",
             value_field="slug",
+            filter_for={
+                'device_id': 'site',
+            }
         )
     )
     device_id = FilterChoiceField(
@@ -3835,6 +3853,9 @@ class PowerConnectionFilterForm(BootstrapMixin, forms.Form):
         widget=APISelectMultiple(
             api_url="/api/dcim/sites/",
             value_field="slug",
+            filter_for={
+                'device_id': 'site',
+            }
         )
     )
     device_id = FilterChoiceField(
@@ -3854,6 +3875,9 @@ class InterfaceConnectionFilterForm(BootstrapMixin, forms.Form):
         widget=APISelectMultiple(
             api_url="/api/dcim/sites/",
             value_field="slug",
+            filter_for={
+                'device_id': 'site',
+            }
         )
     )
     device_id = FilterChoiceField(

In addition, it might be worth creating ConnectionFilterForm from which CableFilterForm and *ConnectionFilterForm inherit for the sake of consistency (similar thing would need to be done in the filterset), but this may be out of scope of this issue.

@hSaria commented on GitHub (Feb 6, 2020): Fairly simple. This is somewhat similar to #3122. If there are no objections, I'd like to work on this (I've missed adding `filter_for` on the `site` field for `device_id`, so I'd improve that in the process). Edit: or just `git apply` this: ```diff diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py index 34f18f6d..e9169523 100644 --- a/netbox/dcim/forms.py +++ b/netbox/dcim/forms.py @@ -84,7 +84,18 @@ class DeviceComponentFilterForm(BootstrapMixin, forms.Form): to_field_name='slug', widget=APISelectMultiple( api_url="/api/dcim/sites/", - value_field="slug" + value_field="slug", + filter_for={ + 'device_id': 'site', + } + ) + ) + device_id = FilterChoiceField( + queryset=Device.objects.all(), + required=False, + label='Device', + widget=APISelectMultiple( + api_url='/api/dcim/devices/', ) ) @@ -3642,6 +3653,7 @@ class CableFilterForm(BootstrapMixin, forms.Form): value_field="slug", filter_for={ 'rack_id': 'site', + 'device_id': 'site', } ) ) @@ -3663,6 +3675,9 @@ class CableFilterForm(BootstrapMixin, forms.Form): widget=APISelectMultiple( api_url="/api/dcim/racks/", null_option=True, + filter_for={ + 'device_id': 'rack_id', + } ) ) type = forms.MultipleChoiceField( @@ -3816,6 +3831,9 @@ class ConsoleConnectionFilterForm(BootstrapMixin, forms.Form): widget=APISelectMultiple( api_url="/api/dcim/sites/", value_field="slug", + filter_for={ + 'device_id': 'site', + } ) ) device_id = FilterChoiceField( @@ -3835,6 +3853,9 @@ class PowerConnectionFilterForm(BootstrapMixin, forms.Form): widget=APISelectMultiple( api_url="/api/dcim/sites/", value_field="slug", + filter_for={ + 'device_id': 'site', + } ) ) device_id = FilterChoiceField( @@ -3854,6 +3875,9 @@ class InterfaceConnectionFilterForm(BootstrapMixin, forms.Form): widget=APISelectMultiple( api_url="/api/dcim/sites/", value_field="slug", + filter_for={ + 'device_id': 'site', + } ) ) device_id = FilterChoiceField( ``` In addition, it might be worth creating `ConnectionFilterForm` from which `CableFilterForm` and `*ConnectionFilterForm` inherit for the sake of consistency (similar thing would need to be done in the filterset), but this may be out of scope of this issue.
adam commented 2025-12-29 18:27:25 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Feb 6, 2020):

Fairly simple. This is somewhat similar to #3122. If there are no objections, I'd like to work on this

Done

I've missed adding filter_for on the site field for device_id, so I'd improve that in the process

Not sure @jeremystretch view on this, but I would probably want this as a separate Issue/PR

@DanSheps commented on GitHub (Feb 6, 2020): > Fairly simple. This is somewhat similar to #3122. If there are no objections, I'd like to work on this Done > I've missed adding `filter_for` on the `site` field for `device_id`, so I'd improve that in the process Not sure @jeremystretch view on this, but I would probably want this as a separate Issue/PR
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?