starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Drop the family column from IP objects #3267

New Issue
Closed
opened 2025-12-29 18:27:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:27:15 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 3, 2020).

Proposed Changes

Drop the family column from the table for each IP object (aggregated, prefixes, and IP addresses). This column indicates the address family (IP version): 4 or 6.

Justification

  1. There is no need to explicitly store this data in the table, as it is implied by the address itself.
  2. Removing it obviates the need for manual population when creating objects via bulk_create() for testing purposes.

Although the column will be removed, we should maintain the family fields in the relevant API serializers. Not only for backward-compatability, but because there is some value in explicitly stating the IP family. (These have been and will remain read-only fields.)

We'll also preserve the family query filter by leveraging PostgreSQL's family() function.

Originally created by @jeremystretch on GitHub (Feb 3, 2020). ### Proposed Changes Drop the `family` column from the table for each IP object (aggregated, prefixes, and IP addresses). This column indicates the address family (IP version): `4` or `6`. ### Justification 1. There is no need to explicitly store this data in the table, as it is implied by the address itself. 2. Removing it obviates the need for manual population when creating objects via `bulk_create()` for testing purposes. Although the column will be removed, we should maintain the `family` fields in the relevant API serializers. Not only for backward-compatability, but because there is some value in explicitly stating the IP family. (These have been and will remain read-only fields.) We'll also preserve the `family` query filter by leveraging PostgreSQL's [`family()` function](https://www.postgresql.org/docs/9.6/functions-net.html).
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:27:15 +01:00
adam closed this issue 2025-12-29 18:27:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3267
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?