starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Comments field missing label on bulk edit #3233

New Issue
Closed
opened 2025-12-29 18:26:56 +01:00 by adam · 4 comments
adam commented 2025-12-29 18:26:56 +01:00
Owner
Copy Link

Originally created by @hSaria on GitHub (Jan 28, 2020).

Environment

  • Python version: 3.6.8
  • NetBox version: 2.7.2

Steps to Reproduce

  1. Navigate to racks list /dcim/racks/
  2. Select a rack and then click the Edit selected button

This affects bulk edit forms for Rack, Cluster, Virtual Machine, and Provider.

Expected Behavior

The comments field on the right has a label

Observed Behavior

A mysterious field appears to have no label
image

Originally created by @hSaria on GitHub (Jan 28, 2020). <!-- NOTE: This form is only for reproducible bugs. If you need assistance with NetBox installation, or if you have a general question, DO NOT open an issue. Instead, post to our mailing list: https://groups.google.com/forum/#!forum/netbox-discuss Please describe the environment in which you are running NetBox. Be sure that you are running an unmodified instance of the latest stable release before submitting a bug report. --> ### Environment * Python version: 3.6.8 * NetBox version: 2.7.2 ### Steps to Reproduce 1. Navigate to racks list `/dcim/racks/` 2. Select a rack and then click the `Edit selected` button > This affects bulk edit forms for Rack, Cluster, Virtual Machine, and Provider. ### Expected Behavior The comments field on the right has a label ### Observed Behavior A mysterious field appears to have no label <img width="396" alt="image" src="https://user-images.githubusercontent.com/34197532/73301257-56b48a00-420a-11ea-8538-9590fc5c12f8.png">
adam added the type: bugstatus: accepted labels 2025-12-29 18:26:56 +01:00
adam closed this issue 2025-12-29 18:26:57 +01:00
adam commented 2025-12-29 18:26:57 +01:00
Author
Owner
Copy Link

@hSaria commented on GitHub (Jan 28, 2020):

Just needs a quick git apply of:

diff --git a/netbox/circuits/forms.py b/netbox/circuits/forms.py
index d5d78e7..b2ccde9 100644
--- a/netbox/circuits/forms.py
+++ b/netbox/circuits/forms.py
@@ -89,7 +89,8 @@ class ProviderBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdi
         label='Admin contact'
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )
 
     class Meta:
diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py
index e713d2c..cb301a4 100644
--- a/netbox/dcim/forms.py
+++ b/netbox/dcim/forms.py
@@ -676,7 +676,8 @@ class RackBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEditFor
         widget=StaticSelect2()
     )
     comments = CommentField(
-        widget=SmallTextarea
+        widget=SmallTextarea,
+        label='Comments'
     )
 
     class Meta:
diff --git a/netbox/virtualization/forms.py b/netbox/virtualization/forms.py
index ae516fc..ed1e5e2 100644
--- a/netbox/virtualization/forms.py
+++ b/netbox/virtualization/forms.py
@@ -171,7 +171,8 @@ class ClusterBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdit
         )
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )
 
     class Meta:
@@ -535,7 +536,8 @@ class VirtualMachineBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldB
         label='Disk (GB)'
     )
     comments = CommentField(
-        widget=SmallTextarea()
+        widget=SmallTextarea(),
+        label='Comments'
     )
 
     class Meta:
@hSaria commented on GitHub (Jan 28, 2020): Just needs a quick `git apply` of: ```diff diff --git a/netbox/circuits/forms.py b/netbox/circuits/forms.py index d5d78e7..b2ccde9 100644 --- a/netbox/circuits/forms.py +++ b/netbox/circuits/forms.py @@ -89,7 +89,8 @@ class ProviderBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdi label='Admin contact' ) comments = CommentField( - widget=SmallTextarea() + widget=SmallTextarea(), + label='Comments' ) class Meta: diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py index e713d2c..cb301a4 100644 --- a/netbox/dcim/forms.py +++ b/netbox/dcim/forms.py @@ -676,7 +676,8 @@ class RackBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEditFor widget=StaticSelect2() ) comments = CommentField( - widget=SmallTextarea + widget=SmallTextarea, + label='Comments' ) class Meta: diff --git a/netbox/virtualization/forms.py b/netbox/virtualization/forms.py index ae516fc..ed1e5e2 100644 --- a/netbox/virtualization/forms.py +++ b/netbox/virtualization/forms.py @@ -171,7 +171,8 @@ class ClusterBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEdit ) ) comments = CommentField( - widget=SmallTextarea() + widget=SmallTextarea(), + label='Comments' ) class Meta: @@ -535,7 +536,8 @@ class VirtualMachineBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldB label='Disk (GB)' ) comments = CommentField( - widget=SmallTextarea() + widget=SmallTextarea(), + label='Comments' ) class Meta: ```
adam commented 2025-12-29 18:26:57 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 28, 2020):

Related to #3575

@jeremystretch commented on GitHub (Jan 28, 2020): Related to #3575
adam commented 2025-12-29 18:26:57 +01:00
Author
Owner
Copy Link

@hSaria commented on GitHub (Jan 28, 2020):

And also to #713

@hSaria commented on GitHub (Jan 28, 2020): And also to #713
adam commented 2025-12-29 18:26:58 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 28, 2020):

We'll get it one day. 😆

@jeremystretch commented on GitHub (Jan 28, 2020): We'll get it one day. :laughing:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3233
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?