starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove unused jQuery file #3203

New Issue
Closed
opened 2025-12-29 18:26:41 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:26:41 +01:00
Owner
Copy Link

Originally created by @mtbutler07 on GitHub (Jan 21, 2020).

Proposed Changes

Remove the (seemingly) unused jQuery library (v1.12.4) from the project-static directory.
netbox/project-static/jquery-ui-1.12.1/external/jquery/jquery.js

Justification

  1. I could not find where this version of jQuery was actually being used.
  2. Vulnerability scanner is flagging the library and referencing XSS vulnerabilities CVE-2019-11358
Originally created by @mtbutler07 on GitHub (Jan 21, 2020). <!-- NOTE: This type of issue should be opened only by those reasonably familiar with NetBox's code base and interested in contributing to its development. Describe the proposed change(s) in detail. --> ### Proposed Changes Remove the (seemingly) unused jQuery library (v1.12.4) from the project-static directory. [netbox/project-static/jquery-ui-1.12.1/external/jquery/jquery.js](https://github.com/netbox-community/netbox/blob/develop/netbox/project-static/jquery-ui-1.12.1/external/jquery/jquery.js) <!-- Provide justification for the proposed change(s). --> ### Justification 1. I could not find where this version of jQuery was actually being used. 2. Vulnerability scanner is flagging the library and referencing XSS vulnerabilities CVE-2019-11358
adam closed this issue 2025-12-29 18:26:42 +01:00
adam commented 2025-12-29 18:26:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 23, 2020):

NetBox merely packages the jquery-ui release as published. We are currently including the most recent release, although it appears a bug has been opened for this upstream: https://bugs.jqueryui.com/ticket/15353

As we don't have the development resources to pick apart the library and determine for certain whether it is safe to do so, I'm extremely hesitant to simply remove the file. Doing so may break components of the UI that we are unable to reliably test for ahead of time.

I think it's fair to defer to the user: If required to satisfy whatever compliance checks are in place, go ahead and delete the file from your local installation as a workaround (with the understanding that components of the UI might break). Otherwise, we'll wait for the packaged library to be addressed upstream.

@jeremystretch commented on GitHub (Jan 23, 2020): NetBox merely packages the `jquery-ui` release as published. We are currently including the most recent release, although it appears a bug has been opened for this upstream: https://bugs.jqueryui.com/ticket/15353 As we don't have the development resources to pick apart the library and determine for certain whether it is safe to do so, I'm extremely hesitant to simply remove the file. Doing so may break components of the UI that we are unable to reliably test for ahead of time. I think it's fair to defer to the user: If required to satisfy whatever compliance checks are in place, go ahead and delete the file from your local installation as a workaround (with the understanding that components of the UI _might_ break). Otherwise, we'll wait for the packaged library to be addressed upstream.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?