starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove ChainedFieldsMixin #3156

New Issue
Closed
opened 2025-12-29 18:26:11 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:26:11 +01:00
Owner
Copy Link

Originally created by @hSaria on GitHub (Jan 13, 2020).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Remove the ChainedFieldsMixin, ChainedModelChoiceField, and ChainedModelMultipleChoiceField.

Justification

Chaining has been replaced with APISelect's filter_for and is no longer required. It updates the queryset, but it is entirely ignored by the API call. And ever since #3812, only the selected option (if any) in the queryset is rendered, so limiting makes very little difference.

Originally created by @hSaria on GitHub (Jan 13, 2020). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Remove the `ChainedFieldsMixin`, `ChainedModelChoiceField`, and `ChainedModelMultipleChoiceField`. ### Justification Chaining has been replaced with APISelect's `filter_for` and is no longer required. It updates the queryset, but it is entirely ignored by the API call. And ever since #3812, only the selected option (if any) in the queryset is rendered, so limiting makes very little difference.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:26:11 +01:00
adam closed this issue 2025-12-29 18:26:11 +01:00
adam commented 2025-12-29 18:26:12 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 17, 2020):

This isn't as simple as just ripping out the chained fields logic, unfortunately. There's more going on here than UI rendering: Foreign key fields frequently need to have their querysets limited in various scenarios to avoid thrashing the database during form validation. It's no doubt something we should look into eventually but it's a huge project and not a priority at this time.

@jeremystretch commented on GitHub (Jan 17, 2020): This isn't as simple as just ripping out the chained fields logic, unfortunately. There's more going on here than UI rendering: Foreign key fields frequently need to have their querysets limited in various scenarios to avoid thrashing the database during form validation. It's no doubt something we should look into eventually but it's a huge project and not a priority at this time.
adam commented 2025-12-29 18:26:12 +01:00
Author
Owner
Copy Link

@hSaria commented on GitHub (Feb 10, 2020):

With #4108 implemented, would it now be safe to remove chaining as the APISelect now limits the queryset to only the existing selection?

@hSaria commented on GitHub (Feb 10, 2020): With #4108 implemented, would it now be safe to remove chaining as the APISelect now limits the queryset to only the existing selection?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?