Update all templates to use the button templatetag #3065

New Issue

adam · 2025-12-29T18:25:17+01:00

adam commented

2025-12-29 18:25:17 +01:00

Originally created by @jeremystretch on GitHub (Dec 13, 2019).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Update all templates to use the custom {% xxx_button %} tag for creating links to add/edit/delete objects.

Justification

This replaces many instances of boilerplate code and reduces the opportunity for error.

Originally created by @jeremystretch on GitHub (Dec 13, 2019). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Update all templates to use the custom `{% xxx_button %}` tag for creating links to add/edit/delete objects. ### Justification This replaces many instances of boilerplate code and reduces the opportunity for error.

adam added the status: accepted type: housekeeping labels 2025-12-29 18:25:17 +01:00

adam closed this issue

2025-12-29 18:25:17 +01:00

adam commented

2025-12-29 18:25:17 +01:00

@hSaria commented on GitHub (Dec 14, 2019):

Shall I do the same for the copy button? It'll make it easier to dot copy buttons in other places, like the shipping address of a site, or the rendered config context of a device.

@hSaria commented on GitHub (Dec 14, 2019): Shall I do the same for the copy button? It'll make it easier to dot copy buttons in other places, like the shipping address of a site, or the rendered config context of a device.

adam commented

2025-12-29 18:25:18 +01:00

@jeremystretch commented on GitHub (Dec 16, 2019):

@hSaria maybe, but it might be more difficult given that the copy buttons aren't always in a standard location, and they have to reference other elements. Take a shot at it if you think it's worthwhile.

@jeremystretch commented on GitHub (Dec 16, 2019): @hSaria maybe, but it might be more difficult given that the copy buttons aren't always in a standard location, and they have to reference other elements. Take a shot at it if you think it's worthwhile.

adam commented

2025-12-29 18:25:18 +01:00

@hSaria commented on GitHub (Dec 16, 2019):

Yeah, I thought about this for a bit and I can think of two ways to do it:

Create different variants (lots of duplicate code, so probably not this)
Use additional arguments to dictate the output, like so:

btn-clipboardjs to be used by ClipboardJS for event delegation

# template
<a class="btn btn-clipboardjs {{ style }}" data-clipboard-target="{{ target }}">
    <span class="fa fa-copy" aria-hidden="true"></span>{% if verbose %} Copy {% endif %}
</a>

# example usage
{% copy_button 'shipping_address' 'btn-xs' verbose=True %}
               ^ target           ^ style  ^ kwargs

It's really up to you. I just saw this ticket and thought "Huh... Neat." It depends if you think we'll get more instances of #3761 and #2638, perhaps on data that is not human-friendly (e.g. serial number) or where accuracy is needed (e.g. shipping address), but again, I'll leave this for you to decide as you'll know what's best for the project – I'm happy to help where I can :)

@hSaria commented on GitHub (Dec 16, 2019): Yeah, I thought about this for a bit and I can think of two ways to do it: 1. Create different variants (lots of duplicate code, so probably not this) 2. Use additional arguments to dictate the output, like so: > `btn-clipboardjs` to be used by ClipboardJS for event delegation ``` # template <a class="btn btn-clipboardjs {{ style }}" data-clipboard-target="{{ target }}"> <span class="fa fa-copy" aria-hidden="true"></span>{% if verbose %} Copy {% endif %} </a> # example usage {% copy_button 'shipping_address' 'btn-xs' verbose=True %} ^ target ^ style ^ kwargs ``` It's really up to you. I just saw this ticket and thought "Huh... Neat." It depends if you think we'll get more instances of #3761 and #2638, perhaps on data that is not human-friendly (e.g. serial number) or where accuracy is needed (e.g. shipping address), but again, I'll leave this for you to decide as you'll know what's best for the project – I'm happy to help where I can :)

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#3065