starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Standardize naming of FilterSet classes #3043

New Issue
Closed
opened 2025-12-29 18:25:06 +01:00 by adam · 3 comments
adam commented 2025-12-29 18:25:06 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Dec 5, 2019).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Ensure that all child classes of Django's FilterSet class end in FilterSet (not just Filter) and rename the filter property on view classes to filterset.

Justification

This makes for cleaner code and should help reduce confusion when distinguishing between a filter set and individual filters.

Originally created by @jeremystretch on GitHub (Dec 5, 2019). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Ensure that all child classes of Django's `FilterSet` class end in `FilterSet` (not just `Filter`) and rename the `filter` property on view classes to `filterset`. ### Justification This makes for cleaner code and should help reduce confusion when distinguishing between a filter set and individual filters.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:25:06 +01:00
adam closed this issue 2025-12-29 18:25:06 +01:00
adam commented 2025-12-29 18:25:06 +01:00
Author
Owner
Copy Link

@hSaria commented on GitHub (Jan 3, 2020):

Can I take a swing at this or would you prefer to do it yourself (you know the project more so you may notice other things to change while fixing this issue)?

Also, do you want to wait until after v2.7 before doing this? I imagine merging this change into develop-2.7 would be a mess of conflicts and would probably miss a couple of new filters only present in v2.7.

@hSaria commented on GitHub (Jan 3, 2020): Can I take a swing at this or would you prefer to do it yourself (you know the project more so you may notice other things to change while fixing this issue)? Also, do you want to wait until after v2.7 before doing this? I imagine merging this change into `develop-2.7` would be a mess of conflicts and would probably miss a couple of new filters only present in v2.7.
adam commented 2025-12-29 18:25:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 3, 2020):

I'll take this on. It needs to be coordinated carefully to avoid invalidating other work. Thanks though!

@jeremystretch commented on GitHub (Jan 3, 2020): I'll take this on. It needs to be coordinated carefully to avoid invalidating other work. Thanks though!
adam commented 2025-12-29 18:25:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 10, 2020):

Merged into develop-2.7

@jeremystretch commented on GitHub (Jan 10, 2020): Merged into `develop-2.7`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#3043
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?