starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Display port-id in LLDP panel #2967

New Issue
Closed
opened 2025-12-29 18:24:08 +01:00 by adam · 6 comments
adam commented 2025-12-29 18:24:08 +01:00
Owner
Copy Link

Originally created by @BegBlev on GitHub (Oct 21, 2019).

Originally assigned to: @BegBlev on GitHub.

Environment

  • Python version: 3.7.3
  • NetBox version: 2.5.11

Proposed Functionality

Currently, when displaying the LLDP tab on a JunOS device, the "port description" is displayed if present in the equipment.
image

The reason for that is that Napalm used function is "get_lldp_neighbors". This function returns "port description" in the "port" field if available. If not it returns "port-id".
This does not seem the best behaviour as the LLDP panel with its color code (white, blue, green and red) is used to compare Netbox declared connectivity to real (LLDP) connectivity.

The proposed enhancement consists in using "get_lldp_neighbors_detail" Napalm function. The use of this function allows to explicitly retrieve LLDP "port-id".
image

Use Case

Using "port-id" instead of "port description" allows to easily check connectivity consistency.

Database Changes

None

External Dependencies

None

Originally created by @BegBlev on GitHub (Oct 21, 2019). Originally assigned to: @BegBlev on GitHub. ### Environment * Python version: 3.7.3 * NetBox version: 2.5.11 ### Proposed Functionality Currently, when displaying the LLDP tab on a JunOS device, the "port description" is displayed if present in the equipment. ![image](https://user-images.githubusercontent.com/27002365/67210213-f945bb80-f418-11e9-9687-12dd165886dd.png) The reason for that is that Napalm used function is "get_lldp_neighbors". This function returns "port description" in the "port" field if available. If not it returns "port-id". This does not seem the best behaviour as the LLDP panel with its color code (white, blue, green and red) is used to compare Netbox declared connectivity to real (LLDP) connectivity. The proposed enhancement consists in using "get_lldp_neighbors_detail" Napalm function. The use of this function allows to explicitly retrieve LLDP "port-id". ![image](https://user-images.githubusercontent.com/27002365/67210306-25f9d300-f419-11e9-9664-103e06f54759.png) ### Use Case Using "port-id" instead of "port description" allows to easily check connectivity consistency. ### Database Changes None ### External Dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 18:24:08 +01:00
adam closed this issue 2025-12-29 18:24:08 +01:00
adam commented 2025-12-29 18:24:08 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 21, 2019):

This issue has been closed as it does not conform to one of the provided templates as required by the contributing guide. If you'd like to request that your issue be re-opened, please first update the content so that it matches the appropriate template (this may require rewriting your issue entirely).

@jeremystretch commented on GitHub (Oct 21, 2019): This issue has been closed as it does not conform to one of the [provided templates](https://github.com/digitalocean/netbox/issues/new/choose) as required by the [contributing guide](https://github.com/digitalocean/netbox/blob/master/CONTRIBUTING.md). If you'd like to request that your issue be re-opened, please first update the content so that it matches the appropriate template (this may require rewriting your issue entirely).
adam commented 2025-12-29 18:24:09 +01:00
Author
Owner
Copy Link

@BegBlev commented on GitHub (Oct 23, 2019):

Sorry for not having followed the provided template.
I think it is OK now.
Could you please reconsider opening the case?

@BegBlev commented on GitHub (Oct 23, 2019): Sorry for not having followed the provided template. I think it is OK now. Could you please reconsider opening the case?
adam commented 2025-12-29 18:24:09 +01:00
Author
Owner
Copy Link

@BegBlev commented on GitHub (Oct 23, 2019):

This patch is a 4 lines source modification and is already ready and working in our Netbox instance.

@BegBlev commented on GitHub (Oct 23, 2019): This patch is a 4 lines source modification and is already ready and working in our Netbox instance.
adam commented 2025-12-29 18:24:09 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Oct 23, 2019):

Could you provide me with the patch here? I would like to test this before we decide to accept/not accept.

@DanSheps commented on GitHub (Oct 23, 2019): Could you provide me with the patch here? I would like to test this before we decide to accept/not accept.
adam commented 2025-12-29 18:24:09 +01:00
Author
Owner
Copy Link

@BegBlev commented on GitHub (Oct 25, 2019):

You can directly get the modification from my netbox fork.
https://github.com/BegBlev/netbox
Branch is 'lldp-port-id'

If you prefer a patch file... just let me know.

Regards
Vince

@BegBlev commented on GitHub (Oct 25, 2019): You can directly get the modification from my netbox fork. https://github.com/BegBlev/netbox Branch is 'lldp-port-id' If you prefer a patch file... just let me know. Regards Vince
adam commented 2025-12-29 18:24:09 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 25, 2019):

@BegBlev please submit a pull request with your changes adhering to the contributing guide.

@jeremystretch commented on GitHub (Oct 25, 2019): @BegBlev please submit a pull request with your changes adhering to the [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?