starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Queue changelog objects for deletion events the same as creates/updates #2828

New Issue
Closed
opened 2025-12-29 18:22:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:22:33 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Aug 26, 2019).

Proposed Changes

Currently, ObjectChanges which represent object creations/updates are queued up during a request and saved to the database (by ObjectChangeMiddleware) only after the request completes. ObjectChanges for deletion events, however, are written immediately. This is because the serialized representation of a deleted object must be generated prior to any related objects being deleted.

This issue seeks to queue deletion ObjectChanges in the same manner as the others. This should be doable by tweaking all log_change() methods to return a new ObjectChange for queuing rather than creating it immediately. Then, we can simply queue up the unsaved ObjectChanges (each of which contains a serialized representation of its respective object) to be written to the database once the request completes.

Justification

By not logging any ObjectChanges until after a request completes, we provide a more sensible behavior and simpler rollback for scenarios where database transactions need to be rolled back.

Originally created by @jeremystretch on GitHub (Aug 26, 2019). ### Proposed Changes Currently, ObjectChanges which represent object creations/updates are queued up during a request and saved to the database (by ObjectChangeMiddleware) only after the request completes. ObjectChanges for deletion events, however, are written immediately. This is because the serialized representation of a deleted object must be generated prior to any related objects being deleted. This issue seeks to queue deletion ObjectChanges in the same manner as the others. This should be doable by tweaking all `log_change()` methods to return a new ObjectChange for queuing rather than creating it immediately. Then, we can simply queue up the unsaved ObjectChanges (each of which contains a serialized representation of its respective object) to be written to the database once the request completes. ### Justification By not logging any ObjectChanges until after a request completes, we provide a more sensible behavior and simpler rollback for scenarios where database transactions need to be rolled back.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:22:33 +01:00
adam closed this issue 2025-12-29 18:22:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2828
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?