starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Move VLAN assignment to interface edit view from self-contained view #2734

New Issue
Closed
opened 2025-12-29 18:21:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:21:33 +01:00
Owner
Copy Link

Originally created by @DanSheps on GitHub (Jul 10, 2019).

Environment

  • Python version: 3.6
  • NetBox version: 2.6.1

Proposed Functionality

This FR would result in moving the VLAN assignment page back into the main interface edit page. Additionally, add in some JS magic to hide/clear and display those fields depending on whether the mode is Access, Trunk or None.

Use Case

Currently, the VLAN edit interface is fairly bulky and unwieldy. You are required go to another view in order to edit VLANs. You are then required to save and return to the interface edit view.

In addition to being unwieldy, this results in webhooks being fired for the interface model edit when just simply saving vlans (or if you have to switch from Access to Trunk)

Database Changes

None

External Dependencies

None

Required Changes

  • Remove Vlan panel
  • Remove VLAN Assignment view/form
  • Add 2 form fields for "Untagged VLAN" and "Tagged VLANs"
  • Add in some JS Magic
  • Add in validation
Originally created by @DanSheps on GitHub (Jul 10, 2019). ### Environment * Python version: 3.6 * NetBox version: 2.6.1 ### Proposed Functionality This FR would result in moving the VLAN assignment page back into the main interface edit page. Additionally, add in some JS magic to hide/clear and display those fields depending on whether the mode is Access, Trunk or None. ### Use Case Currently, the VLAN edit interface is fairly bulky and unwieldy. You are required go to another view in order to edit VLANs. You are then required to save and return to the interface edit view. In addition to being unwieldy, this results in webhooks being fired for the interface model edit when just simply saving vlans (or if you have to switch from Access to Trunk) ### Database Changes None ### External Dependencies None ### Required Changes * Remove Vlan panel * Remove VLAN Assignment view/form * Add 2 form fields for "Untagged VLAN" and "Tagged VLANs" * Add in some JS Magic * Add in validation
adam added the status: accepted label 2025-12-29 18:21:33 +01:00
adam closed this issue 2025-12-29 18:21:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?