starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

API count shows count of all aggregate tagged items and not count of tags #2650

New Issue
Closed
opened 2025-12-29 18:20:52 +01:00 by adam · 6 comments
adam commented 2025-12-29 18:20:52 +01:00
Owner
Copy Link

Originally created by @pm17788 on GitHub (Jun 4, 2019).

Environment

  • Python version: 3.5.2
  • NetBox version: 2.5.13

Steps to Reproduce

  1. Browse to: https://NetBoxURL/extras/tags, see count of tags (ex: 25)
  2. Browse to: https://NetBoxURL/api/extras/tags, see count which is an aggregate of all tagged items, rather then the count of distinct tags in NetBox

Expected Behavior

API count of tags should match the WebUI and the API

Observed Behavior

API count of tags doesn't match the WebUI, or the behavior of count variable on other API endpoints.

Originally created by @pm17788 on GitHub (Jun 4, 2019). ### Environment * Python version: 3.5.2 * NetBox version: 2.5.13 ### Steps to Reproduce 1. Browse to: https://NetBoxURL/extras/tags, see count of tags (ex: 25) 2. Browse to: https://NetBoxURL/api/extras/tags, see count which is an aggregate of *all* tagged items, rather then the count of distinct tags in NetBox ### Expected Behavior API count of tags should match the WebUI and the API ### Observed Behavior API count of tags doesn't match the WebUI, or the behavior of `count` variable on other API endpoints.
adam added the type: bugstatus: accepted labels 2025-12-29 18:20:52 +01:00
adam closed this issue 2025-12-29 18:20:53 +01:00
adam commented 2025-12-29 18:20:53 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jun 4, 2019):

Confirmed this is still present.

This looks to be to do with some performance optimizations made in the Pagination class.

@DanSheps commented on GitHub (Jun 4, 2019): Confirmed this is still present. This looks to be to do with some performance optimizations made in the Pagination class.
adam commented 2025-12-29 18:20:53 +01:00
Author
Owner
Copy Link

@KhaledTo commented on GitHub (Jun 4, 2019):

If my understanding is correct the count in /api/extras/tags should show the number of distinct tags like in /extras/tags.

I can take this, except if @pm17788 you want to work on this fix.

@KhaledTo commented on GitHub (Jun 4, 2019): If my understanding is correct the count in ` /api/extras/tags` should show the number of distinct tags like in `/extras/tags`. I can take this, except if @pm17788 you want to work on this fix.
adam commented 2025-12-29 18:20:54 +01:00
Author
Owner
Copy Link

@pm17788 commented on GitHub (Jun 5, 2019):

@KhaledTo : Sadly, my Python-Fu is still weak. Still learning, so I'm not ready to go committing code yet.

@pm17788 commented on GitHub (Jun 5, 2019): @KhaledTo : Sadly, my Python-Fu is still weak. Still learning, so I'm not ready to go committing code yet.
adam commented 2025-12-29 18:20:54 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 5, 2019):

Looks like I fixed a slightly different problem under #3116.

FYI this has already been fixed under develop-2.6. The root issue stems from the use of distinct=True when annotating the TaggedItem count on the queryset. In v2.6, we've started using subqueries instead.

Not sure it makes sense to backport this utility function to the v2.5 train but we should be able to do a one-off implementation.

@jeremystretch commented on GitHub (Jun 5, 2019): Looks like I fixed a slightly different problem under #3116. FYI this has already been fixed under `develop-2.6`. The root issue stems from the use of `distinct=True` when annotating the TaggedItem count on the queryset. In v2.6, we've started using [subqueries](https://github.com/digitalocean/netbox/blob/develop-2.6/netbox/utilities/utils.py#L75) instead. Not sure it makes sense to backport this utility function to the v2.5 train but we should be able to do a one-off implementation.
adam commented 2025-12-29 18:20:54 +01:00
Author
Owner
Copy Link

@pm17788 commented on GitHub (Jun 5, 2019):

@jeremystretch : If it is not too tricky to make into 2.5 branch, it'd be awesome. There is some code I'd like to roll out internally, and can't, because of this silly thing :(

@pm17788 commented on GitHub (Jun 5, 2019): @jeremystretch : If it is not too tricky to make into 2.5 branch, it'd be awesome. There is some code I'd like to roll out internally, and can't, because of this silly thing :(
adam commented 2025-12-29 18:20:54 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 20, 2019):

Closing this out as v2.6 is being released today.

@jeremystretch commented on GitHub (Jun 20, 2019): Closing this out as v2.6 is being released today.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?