starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Change Cable.status field from Boolean to Int type #2599

New Issue
Closed
opened 2025-12-29 18:20:16 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:20:16 +01:00
Owner
Copy Link

Originally created by @Grokzen on GitHub (May 9, 2019).

Proposed Changes

The status field on the Cable model is the only status field across all models that is a Boolean type and not a Integer type. This makes it impossible to extend the status property on this model to include other statuses in the future. And it is not streamlined that all status fields is of the same type and works in the same way.

    status = models.BooleanField(
        choices=CONNECTION_STATUS_CHOICES,
        default=CONNECTION_STATUS_CONNECTED
    )

...

# Console/power/interface connection statuses
CONNECTION_STATUS_PLANNED = False
CONNECTION_STATUS_CONNECTED = True
CONNECTION_STATUS_CHOICES = [
    [CONNECTION_STATUS_PLANNED, 'Planned'],
    [CONNECTION_STATUS_CONNECTED, 'Connected'],
]

Justification

Streamline all status fields to the same type and make it possible to extend the status field.

Originally created by @Grokzen on GitHub (May 9, 2019). <!-- NOTE: This type of issue should be opened only by those reasonably familiar with NetBox's code base and interested in contributing to its development. Describe the proposed change(s) in detail. --> ### Proposed Changes The status field on the Cable model is the only status field across all models that is a Boolean type and not a Integer type. This makes it impossible to extend the status property on this model to include other statuses in the future. And it is not streamlined that all status fields is of the same type and works in the same way. ``` status = models.BooleanField( choices=CONNECTION_STATUS_CHOICES, default=CONNECTION_STATUS_CONNECTED ) ... # Console/power/interface connection statuses CONNECTION_STATUS_PLANNED = False CONNECTION_STATUS_CONNECTED = True CONNECTION_STATUS_CHOICES = [ [CONNECTION_STATUS_PLANNED, 'Planned'], [CONNECTION_STATUS_CONNECTED, 'Connected'], ] ``` <!-- Provide justification for the proposed change(s). --> ### Justification Streamline all status fields to the same type and make it possible to extend the status field.
adam closed this issue 2025-12-29 18:20:17 +01:00
adam commented 2025-12-29 18:20:17 +01:00
Author
Owner
Copy Link

@yarnocobussen commented on GitHub (May 9, 2019):

Might be good to comment on this in https://github.com/digitalocean/netbox/issues/3145

@yarnocobussen commented on GitHub (May 9, 2019): Might be good to comment on this in https://github.com/digitalocean/netbox/issues/3145
adam commented 2025-12-29 18:20:17 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 9, 2019):

This would be covered by #3145 if accepted.

@jeremystretch commented on GitHub (May 9, 2019): This would be covered by #3145 if accepted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?