starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Replace all instances of .extra() in QuerySets with annotations #2559

New Issue
Closed
opened 2025-12-29 18:19:57 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:19:57 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Apr 27, 2019).

Proposed Changes

There are several instances where .extra() is used to extend a QuerySet. These should be replaced with .annotate() using RawSQL where necessary.

Justification

.extra() is planned for deprecation.

Originally created by @jeremystretch on GitHub (Apr 27, 2019). ### Proposed Changes There are several instances where `.extra()` is used to extend a QuerySet. These should be replaced with `.annotate()` using `RawSQL` where necessary. ### Justification `.extra()` is [planned for deprecation](https://docs.djangoproject.com/en/2.2/ref/models/querysets/#extra).
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:19:57 +01:00
adam closed this issue 2025-12-29 18:19:57 +01:00
adam commented 2025-12-29 18:19:57 +01:00
Author
Owner
Copy Link

@KhaledTo commented on GitHub (Jun 5, 2019):

Would like to have a look at this.

@KhaledTo commented on GitHub (Jun 5, 2019): Would like to have a look at this.
adam commented 2025-12-29 18:19:57 +01:00
Author
Owner
Copy Link

@kobayashi commented on GitHub (Oct 10, 2019):

closed in e223c88

@kobayashi commented on GitHub (Oct 10, 2019): closed in e223c88
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?