starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Move Device and DeviceType compontent models out of models.py #2533

New Issue
Closed
opened 2025-12-29 18:19:44 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:19:44 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Apr 19, 2019).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

dcim/models.py has gotten pretty cluttered: It currently holds over 60 models. I'd like to reorganize the models into three files under dcim/models/:

  • ComponentTemplateModels
  • ComponentModels
  • Everything else

These will all be imported via dcim/models/__init__.py.

Justification

This should reduce clutter and make it easier to jump around among models when developing.

Originally created by @jeremystretch on GitHub (Apr 19, 2019). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes `dcim/models.py` has gotten pretty cluttered: It currently holds over 60 models. I'd like to reorganize the models into three files under `dcim/models/`: * ComponentTemplateModels * ComponentModels * Everything else These will all be imported via `dcim/models/__init__.py`. ### Justification This should reduce clutter and make it easier to jump around among models when developing.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:19:44 +01:00
adam closed this issue 2025-12-29 18:19:44 +01:00
adam commented 2025-12-29 18:19:45 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 27, 2019):

@lampwins IIRC we briefly discussed the possibility of adopting a new models/ approach for all apps, not just DCIM. I suppose all base models would go in models/__init__.py and other stuff (like device components) would go in e.g. models/components.py. Do you think that makes sense?

@jeremystretch commented on GitHub (May 27, 2019): @lampwins IIRC we briefly discussed the possibility of adopting a new `models/` approach for _all_ apps, not just DCIM. I suppose all base models would go in `models/__init__.py` and other stuff (like device components) would go in e.g. `models/components.py`. Do you think that makes sense?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?