starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Capture ExportTemplate rendering errors more elegantly #2529

New Issue
Closed
opened 2025-12-29 18:19:40 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:19:40 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Apr 18, 2019).

Environment

  • Python version: 3.5.6
  • NetBox version: 2.5.10

Proposed Functionality

Currently, if an ExportTemplate is saved with invalid template code and then run, it will raise an exception which is handled like any other server error (500). Ideally, we should capture the template rendering error and present it in some more elegant fashion so that the user is immediately aware that it's a bug in the template rather than NetBox itself.

Use Case

This would allow for quicker identification of template errors.

Database Changes

None

External Dependencies

None

Originally created by @jeremystretch on GitHub (Apr 18, 2019). ### Environment * Python version: 3.5.6 * NetBox version: 2.5.10 ### Proposed Functionality Currently, if an ExportTemplate is saved with invalid template code and then run, it will raise an exception which is handled like any other server error (500). Ideally, we should capture the template rendering error and present it in some more elegant fashion so that the user is immediately aware that it's a bug in the template rather than NetBox itself. ### Use Case This would allow for quicker identification of template errors. ### Database Changes None ### External Dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 18:19:40 +01:00
adam closed this issue 2025-12-29 18:19:40 +01:00
adam commented 2025-12-29 18:19:41 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 2, 2019):

I should point out that we are already catching TemplateSyntaxError. This extends that logic to catch any exception raised during rendering of the template.

@jeremystretch commented on GitHub (May 2, 2019): I should point out that we are already catching TemplateSyntaxError. This extends that logic to catch _any_ exception raised during rendering of the template.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2529
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?