starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Using just quotes in a device's local context data causes AttributeError #2482

New Issue
Closed
opened 2025-12-29 18:19:15 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:19:15 +01:00
Owner
Copy Link

Originally created by @bdlamprecht on GitHub (Mar 25, 2019).

Environment

  • Python version: 3.6.7
  • NetBox version: 2.5.8

Steps to Reproduce

  1. Edit an existing device
  2. In the Local Config Context Data field, just add empty quotes (i.e. "")
  3. Click Update. No validation error is reported.
  4. When you then view the Config Context tab, the following error occurs:
The complete exception is provided below:
<class 'AttributeError'>

'str' object has no attribute 'items'

Technically, there is no reason to have just quotes in the Local Config Context Data (which is where I assume this error is originating from), there should either:

  1. Have a validation error when attempting to save the object
  2. Display None for bad or invalid data when viewed instead of raise an AttributeError

Expected Behavior

Explained above.

Observed Behavior

Explained above.

Originally created by @bdlamprecht on GitHub (Mar 25, 2019). ### Environment * Python version: 3.6.7 * NetBox version: 2.5.8 ### Steps to Reproduce 1. Edit an existing device 2. In the `Local Config Context Data` field, just add empty quotes (i.e. `""`) 3. Click `Update`. No validation error is reported. 4. When you then view the `Config Context` tab, the following error occurs: ``` The complete exception is provided below: <class 'AttributeError'> 'str' object has no attribute 'items' ``` Technically, there is no reason to have just quotes in the `Local Config Context Data` (which is where I assume this error is originating from), there should either: 1. Have a validation error when attempting to save the object 2. Display `None` for bad or invalid data when viewed instead of raise an `AttributeError` <!-- What did you expect to happen? --> ### Expected Behavior Explained above. <!-- What happened instead? --> ### Observed Behavior Explained above.
adam added the type: bugstatus: accepted labels 2025-12-29 18:19:15 +01:00
adam closed this issue 2025-12-29 18:19:15 +01:00
adam commented 2025-12-29 18:19:16 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 28, 2019):

The JSON data is stored using django.contrib.postgres.fields.JSONField, so I'd rather avoid messing with input validation. I'll tweakget_config_context() to ignore empty data.

@jeremystretch commented on GitHub (Mar 28, 2019): The JSON data is stored using `django.contrib.postgres.fields.JSONField`, so I'd rather avoid messing with input validation. I'll tweak`get_config_context()` to ignore empty data.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?