starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

search for prefixes within a VRF does not work #2479

New Issue
Closed
opened 2025-12-29 18:19:14 +01:00 by adam · 4 comments
adam commented 2025-12-29 18:19:14 +01:00
Owner
Copy Link

Originally created by @JuergenKammer on GitHub (Mar 25, 2019).

Environment

  • Python version: 3.6.8
  • NetBox version: 2.5.8

Steps to Reproduce

  1. Create VRFs
  2. Create Prefixes in different VRFs
  3. Select "IPAM"->"Prefixes"
  4. Use the search area on the right side, select a VRF from which prefixes should be shown, and select "apply"

Expected Behavior

  1. Prefixes in only the selected VRF(s) are shown

Observed Behavior

  1. Prefixes from all VRFs are shown

REASON for the error:

  • the URL which is called when clicking on "apply" ends in something like:
    .../ipam/prefixes/?q=&within_include=&family=&mask_length=&vrf=8&is_pool=

SOLUTION:

it should be:
../ipam/prefixes/?q=&within_include=&family=&mask_length=&vrf_id=8&is_pool=

I.e. the selected vrf is mapped to its id, but the search looks for a vrf named such, not for the vrf_id with that number.

The URL with "vrf_id=..." results in the expected behavior.

Originally created by @JuergenKammer on GitHub (Mar 25, 2019). ### Environment * Python version: 3.6.8 * NetBox version: 2.5.8 ### Steps to Reproduce 1. Create VRFs 2. Create Prefixes in different VRFs 3. Select "IPAM"->"Prefixes" 4. Use the search area on the right side, select a VRF from which prefixes should be shown, and select "apply" <!-- What did you expect to happen? --> ### Expected Behavior 5. Prefixes in only the selected VRF(s) are shown <!-- What happened instead? --> ### Observed Behavior 5. Prefixes from all VRFs are shown ### REASON for the error: - the URL which is called when clicking on "apply" ends in something like: .../ipam/prefixes/?q=&within_include=&family=&mask_length=&vrf=8&is_pool= ### SOLUTION: it should be: ../ipam/prefixes/?q=&within_include=&family=&mask_length=&vrf_id=8&is_pool= I.e. the selected vrf is mapped to its id, but the search looks for a vrf named such, not for the vrf_id with that number. The URL with "vrf_id=..." results in the expected behavior.
adam added the type: bugstatus: accepted labels 2025-12-29 18:19:14 +01:00
adam closed this issue 2025-12-29 18:19:14 +01:00
adam commented 2025-12-29 18:19:14 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Mar 25, 2019):

I am unable to duplicate this on 2.5.8. Please provide a reproducible scenario on 2.5.8. Further, I checked the code and both the filter and form us "rd"

Data Load:

name, rd
VRF1, 1:1
VRF2, 2:2

prefix,vrf,status
192.168.1.0/24,1:1,Active
192.168.1.0/24,2:2,Active

Query:

IPAM->Prefixes
Filter for VRF1
"Apply"

Results:

192.168.1.0/24,1:1,Active

@DanSheps commented on GitHub (Mar 25, 2019): I am unable to duplicate this on 2.5.8. Please provide a reproducible scenario on 2.5.8. Further, I checked the code and both the filter and form us "rd" Data Load: ``` name, rd VRF1, 1:1 VRF2, 2:2 prefix,vrf,status 192.168.1.0/24,1:1,Active 192.168.1.0/24,2:2,Active ``` Query: IPAM->Prefixes Filter for VRF1 "Apply" Results: 192.168.1.0/24,1:1,Active
adam commented 2025-12-29 18:19:14 +01:00
Author
Owner
Copy Link

@JuergenKammer commented on GitHub (Mar 25, 2019):

Ah.
I have NOT defined any rd.
Thus, try again, and define your VRFs without an rd.

This also explains why it could creep in, because RDs have not been optional for along time...

@JuergenKammer commented on GitHub (Mar 25, 2019): Ah. I have NOT defined any rd. Thus, try again, and define your VRFs without an rd. This also explains why it could creep in, because RDs have not been optional for along time...
adam commented 2025-12-29 18:19:15 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Mar 25, 2019):

I see...

This is related to the way ModelMultipleChoiceFilter works, because when it comes up against an invalid value, it returns null to the filter (which filters on nothing so you get everything)

@DanSheps commented on GitHub (Mar 25, 2019): I see... This is related to the way ModelMultipleChoiceFilter works, because when it comes up against an invalid value, it returns null to the filter (which filters on nothing so you get everything)
adam commented 2025-12-29 18:19:15 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Mar 25, 2019):

Any form using vrf rd will be affected.

@DanSheps commented on GitHub (Mar 25, 2019): Any form using vrf rd will be affected.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2479
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?