Device components duplicated in paginated API responses when not filtered by device #2414

New Issue

adam · 2025-12-29T17:25:52+01:00

adam commented

2025-12-29 17:25:52 +01:00

Originally created by @shugotek on GitHub (Feb 28, 2019).

Environment

Python version: 3.6.7
NetBox version: 2.5.7

Steps to Reproduce

1.GET /api/dcim/console-ports/?limit=200&offset=0
2.GET /api/dcim/console-ports/?limit=200&offset=200 (and continue to have all)

Expected Behavior

List all console ports

Observed Behavior

If we compare all page, we have duplicate console ports and we have missing console ports.
If we do a Get with a limit greater than the number of console ports, we don't have any duplicate or missing console ports.

Originally created by @shugotek on GitHub (Feb 28, 2019).  ### Environment * Python version: 3.6.7 * NetBox version: 2.5.7  ### Steps to Reproduce 1.GET /api/dcim/console-ports/?limit=200&offset=0 2.GET /api/dcim/console-ports/?limit=200&offset=200 (and continue to have all)  ### Expected Behavior List all console ports  ### Observed Behavior If we compare all page, we have duplicate console ports and we have missing console ports. If we do a Get with a limit greater than the number of console ports, we don't have any duplicate or missing console ports.

adam added the type: bug status: accepted labels 2025-12-29 17:25:52 +01:00

adam closed this issue

2025-12-29 17:25:52 +01:00

adam commented

2025-12-29 17:25:53 +01:00

@jeremystretch commented on GitHub (Feb 28, 2019):

This applies to all device components and component templates (except interfaces), not just console ports. Code to reproduce:

import requests

url='http://localhost:8000/api/dcim/console-ports/'
params = {
    'limit': 200,
    'offset': 0,
}
r = requests.get(url, params)
ids = [obj['id'] for obj in r.json()['results']]

params['offset'] = 200
r = requests.get(url, params)
for obj in r.json()['results']:
    if obj['id'] in ids:
        print("Duplicate ID: {}".format(obj['id']))

The issue here is that DeviceComponentManager.get_queryset() orders objects only by name, not by unique ID. This is fine when the list is filtered by device, but does not ensure deterministic ordering when the query includes objects with the same name. Nice catch!

@jeremystretch commented on GitHub (Feb 28, 2019): This applies to all device components and component templates (except interfaces), not just console ports. Code to reproduce: ``` import requests url='http://localhost:8000/api/dcim/console-ports/' params = { 'limit': 200, 'offset': 0, } r = requests.get(url, params) ids = [obj['id'] for obj in r.json()['results']] params['offset'] = 200 r = requests.get(url, params) for obj in r.json()['results']: if obj['id'] in ids: print("Duplicate ID: {}".format(obj['id'])) ``` The issue here is that `DeviceComponentManager.get_queryset()` orders objects only by name, not by unique ID. This is fine when the list is filtered by device, but does not ensure deterministic ordering when the query includes objects with the same name. Nice catch!

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#2414