starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

add distinction between OS1 and OS2 for singlemode fiber in constants.py #2370

New Issue
Closed
opened 2025-12-29 17:25:22 +01:00 by adam · 4 comments
adam commented 2025-12-29 17:25:22 +01:00
Owner
Copy Link

Originally created by @fischa on GitHub (Feb 12, 2019).

Environment

  • Python version: 3.6 (from netbox-community docker image)
  • NetBox version: 2.5.5

Proposed Functionality

Addition of OS1 and OS2 singlemode fiber options in constants.py. No changes to workflow or user interface needed as far as I can see. I can add a PR if requested.

Use Case

This is needed for being able to choose from this two types of singlemode fiber for cable "creation". Till now there is just "Singlemode Fiber" available but four types of multimode fiber.

Database Changes

Not that I'm aware of. Name and ID come from constants.py and are probably stored as such in the DB.

External Dependencies

None.

Originally created by @fischa on GitHub (Feb 12, 2019). ### Environment * Python version: 3.6 (from netbox-community docker image) * NetBox version: 2.5.5 ### Proposed Functionality Addition of OS1 and OS2 singlemode fiber options in constants.py. No changes to workflow or user interface needed as far as I can see. I can add a PR if requested. ### Use Case This is needed for being able to choose from this two types of singlemode fiber for cable "creation". Till now there is just "Singlemode Fiber" available but four types of multimode fiber. ### Database Changes Not that I'm aware of. Name and ID come from constants.py and are probably stored as such in the DB. ### External Dependencies None.
adam added the status: acceptedtype: feature labels 2025-12-29 17:25:22 +01:00
adam closed this issue 2025-12-29 17:25:22 +01:00
adam commented 2025-12-29 17:25:23 +01:00
Author
Owner
Copy Link

@fischa commented on GitHub (Feb 12, 2019):

image

@fischa commented on GitHub (Feb 12, 2019): ![image](https://user-images.githubusercontent.com/11302991/52624809-e228f400-2eaf-11e9-9b44-22f44ac4bcf4.png)
adam commented 2025-12-29 17:25:23 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Feb 12, 2019):

As discussed in Slack, there are other types beyond OS1 and OS2, so I would propose keep SMF as 3500, then add OS1 and OS2 as something like 3510, 3520 as they are derivative of the SMF type but rename it Singlemode Fiber (Generic)

@DanSheps commented on GitHub (Feb 12, 2019): As discussed in Slack, there are other types beyond OS1 and OS2, so I would propose keep SMF as 3500, then add OS1 and OS2 as something like 3510, 3520 as they are derivative of the SMF type but rename it Singlemode Fiber (Generic)
adam commented 2025-12-29 17:25:23 +01:00
Author
Owner
Copy Link

@tb-killa commented on GitHub (Feb 14, 2019):

http://www.thefoa.org/tech/ref/basic/fiber.html

I prefer using official Names (see Graphic) if we allow to specify them:
http://www.thefoa.org/tech/ref/basic/FiberFamilyTree.jpg

@tb-killa commented on GitHub (Feb 14, 2019): http://www.thefoa.org/tech/ref/basic/fiber.html I prefer using official Names (see Graphic) if we allow to specify them: http://www.thefoa.org/tech/ref/basic/FiberFamilyTree.jpg
adam commented 2025-12-29 17:25:23 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 15, 2019):

For consistency, I'm going to:

  1. Add a generic MMF type
  2. Keep the existing generic SMF type in place
  3. Add two new types for OS1 and OS2

This leaves it up the user whether they want to specify just MMF or SMF, or a specific class.

@jeremystretch commented on GitHub (Feb 15, 2019): For consistency, I'm going to: 1. Add a generic MMF type 2. Keep the existing generic SMF type in place 3. Add two new types for OS1 and OS2 This leaves it up the user whether they want to specify just MMF or SMF, or a specific class.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?