starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Update calls to super() for Python 3 #2144

New Issue
Closed
opened 2025-12-29 17:22:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 17:22:39 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Nov 27, 2018).

Proposed Changes

Under Python 2, super() must be called with the model and instance referenced explicitly:

class Foo:
    def __init__(self, *args, **kwargs):
        super(Foo, self).__init__(*args, **kwargs)

Python 3 allows for this to be simplified, calling super() with no arguments:

class Foo:
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)

Since NetBox no longer supports Python 2 as of v2.5, we can simplify all super() calls.

Justification

Removes superfluous code

Originally created by @jeremystretch on GitHub (Nov 27, 2018). ### Proposed Changes Under Python 2, `super()` must be called with the model and instance referenced explicitly: ``` class Foo: def __init__(self, *args, **kwargs): super(Foo, self).__init__(*args, **kwargs) ``` Python 3 allows for this to be simplified, calling `super()` with no arguments: ``` class Foo: def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) ``` Since NetBox no longer supports Python 2 as of v2.5, we can simplify all `super()` calls. ### Justification Removes superfluous code
adam added the status: acceptedtype: housekeeping labels 2025-12-29 17:22:39 +01:00
adam closed this issue 2025-12-29 17:22:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2144
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?