starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add FibreChannel SFP28 (32GFC) interface support #2132

New Issue
Closed
opened 2025-12-29 17:22:32 +01:00 by adam · 5 comments
adam commented 2025-12-29 17:22:32 +01:00
Owner
Copy Link

Originally created by @swerveshot on GitHub (Nov 19, 2018).

Environment

  • Python version: 3.6.7
  • NetBox version: v2.5-beta1

Proposed Functionality

Just like issue #2561 I spotted an interface type that is not available in Netbox yet: 32G Fibre Channel (32GFC) SFP28. It would be really nice if you could include it. ❤️

https://www.finisar.com/optical-transceivers/ftlf8532p4bcv

Originally created by @swerveshot on GitHub (Nov 19, 2018). ### Environment * Python version: 3.6.7 * NetBox version: v2.5-beta1 ### Proposed Functionality Just like issue #2561 I spotted an interface type that is not available in Netbox yet: 32G Fibre Channel (32GFC) SFP28. It would be really nice if you could include it. :heart: https://www.finisar.com/optical-transceivers/ftlf8532p4bcv
adam added the status: acceptedtype: feature labels 2025-12-29 17:22:32 +01:00
adam closed this issue 2025-12-29 17:22:32 +01:00
adam commented 2025-12-29 17:22:34 +01:00
Author
Owner
Copy Link

@swerveshot commented on GitHub (Dec 6, 2018):

Hey @jeremystretch!

Thanks for adding the 32GFC support. From what I can tell it's not that hard to add any additional interface types. If I wanted to add even more interface types could I simply fork the project (development tree) and then add them to the 0062_interface_mtu.py and constants.py files?

I was recently made aware by a colleague that there is also a 4x32GFC QSFP28 interface type available (Brocade part number XBR-000275). Would I name it as IFACE_FF_4X32GFC_QSFP28?

@swerveshot commented on GitHub (Dec 6, 2018): Hey @jeremystretch! Thanks for adding the 32GFC support. From what I can tell it's not that hard to add any additional interface types. If I wanted to add even more interface types could I simply fork the project (development tree) and then add them to the 0062_interface_mtu.py and constants.py files? I was recently made aware by a colleague that there is also a 4x32GFC QSFP28 interface type available (Brocade part number [XBR-000275).](https://docs.broadcom.com/docs/12379902) Would I name it as IFACE_FF_4X32GFC_QSFP28?
adam commented 2025-12-29 17:22:35 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Dec 7, 2018):

@swerveshot You would:

  • add them to the constants.py
  • python3 /netbox/manage.py makemigrations

As a best practice, I would do the following:

  • Fork the repository
  • git clone https://github.com/[you]/netbox
  • git checkout develop
  • git checkout -B <issue#>-description
  • make changes
  • python3 /netbox/manage.py makemigrations
  • git add .
  • git commit -m"Fixes #<issue#> - Proper description"
    • You can go further if you want and list out everything that was changed in a more detailed commit message
  • git push origin <issue#>-description
  • Open a pull request

This is just what I would do, you can really do it however you want, but I would say work in adifferent branch then develop, otherwise you end up polluting the pull request with extra fluff as well.

@DanSheps commented on GitHub (Dec 7, 2018): @swerveshot You would: * add them to the constants.py * python3 <pathtonetbox>/netbox/manage.py makemigrations As a best practice, I would do the following: * Fork the repository * git clone https://github.com/[you]/netbox * git checkout develop * git checkout -B <issue#>-description * make changes * python3 <pathtonetbox>/netbox/manage.py makemigrations * git add . * git commit -m"Fixes #<issue#> - Proper description" * You can go further if you want and list out everything that was changed in a more detailed commit message * git push origin <issue#>-description * Open a pull request This is just what I would do, you can really do it however you want, but I would say work in adifferent branch then develop, otherwise you end up polluting the pull request with extra fluff as well.
adam commented 2025-12-29 17:22:35 +01:00
Author
Owner
Copy Link

@swerveshot commented on GitHub (Dec 7, 2018):

Thanks for your help @DanSheps. I'm a novice git user and my development skills are nearly non-existent. I had some issues with running manage.py makemigrations. But most of the issues were resolved after installing the requirements for netbox by using the documentation. Is a fully functional installation of netbox required to run this script?

@swerveshot commented on GitHub (Dec 7, 2018): Thanks for your help @DanSheps. I'm a novice git user and my development skills are nearly non-existent. I had some issues with running `manage.py makemigrations`. But most of the issues were resolved after installing the requirements for netbox by using the [documentation](https://netbox.readthedocs.io/en/stable/installation/2-netbox/). Is a fully functional installation of netbox required to run this script?
adam commented 2025-12-29 17:22:35 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Dec 8, 2018):

Yes, you would need a fully functional install of netbox, including PostgreSQL

@DanSheps commented on GitHub (Dec 8, 2018): Yes, you would need a fully functional install of netbox, including PostgreSQL
adam commented 2025-12-29 17:22:35 +01:00
Author
Owner
Copy Link

@swerveshot commented on GitHub (Dec 9, 2018):

Okay @DanSheps now it gets interesting. Do you have any thoughts on how to get you own fork up-and-running really fast? I tried the Vagrant route and that works. All you need to do is change the URL of the repo. But it would be really awesome if I could use Docker Playground and avoid having to host my own Netbox fork in a VM. But unfortunately I have no idea how to accomplish this.

@swerveshot commented on GitHub (Dec 9, 2018): Okay @DanSheps now it gets interesting. Do you have any thoughts on how to get you own fork up-and-running really fast? I tried the [Vagrant](https://github.com/ryanmerolle/netbox-vagrant) route and that works. All you need to do is change the URL of the repo. But it would be really awesome if I could use [Docker Playground](https://play-with-docker.com) and avoid having to host my own Netbox fork in a VM. But unfortunately I have no idea how to accomplish this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#2132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?