starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Webhook signals refactor #1876

New Issue
Closed
opened 2025-12-29 17:20:01 +01:00 by adam · 1 comment
adam commented 2025-12-29 17:20:01 +01:00
Owner
Copy Link

Originally created by @lampwins on GitHub (Jul 29, 2018).

Proposed Changes

With the addition of the Changelog feature, a new ChangeLoggingMiddleware middleware was created to take care of the object signals on a request. This is an elegant solution to work around problems with foreign key relationships not being available at the time of the original object creation. We should refactor the Webhook signal handling to piggyback this middleware.

Justification

#2260 was originally opened with the purpose of fixing #2137 but the scope has changed to the aforementioned refactor. This will serve as this issue for that PR.

Ultimately this will reduce some of the complexity in the Webhook implementation.

Originally created by @lampwins on GitHub (Jul 29, 2018). <!-- NOTE: This type of issue should be opened only by those reasonably familiar with NetBox's code base and interested in contributing to its development. Describe the proposed change(s) in detail. --> ### Proposed Changes With the addition of the Changelog feature, a new `ChangeLoggingMiddleware` middleware was created to take care of the object signals on a request. This is an elegant solution to work around problems with foreign key relationships not being available at the time of the original object creation. We should refactor the Webhook signal handling to piggyback this middleware. <!-- Provide justification for the proposed change(s). --> ### Justification #2260 was originally opened with the purpose of fixing #2137 but the scope has changed to the aforementioned refactor. This will serve as this issue for that PR. Ultimately this will reduce some of the complexity in the Webhook implementation.
adam closed this issue 2025-12-29 17:20:01 +01:00
adam commented 2025-12-29 17:20:02 +01:00
Author
Owner
Copy Link

@lampwins commented on GitHub (Jul 30, 2018):

taken care of in #2260

@lampwins commented on GitHub (Jul 30, 2018): taken care of in #2260
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?