Make number of search results displayed a configurable value #1835

Closed
opened 2025-12-29 17:19:36 +01:00 by adam · 2 comments
Owner

Originally created by @reshippie on GitHub (Jul 10, 2018).

Issue type

[X] Feature request
[ ] Bug report
[ ] Documentation
[ ] Housekeeping

Environment

  • Python version: 2.7.10
  • NetBox version: 2.3.6-dev

Description

Currently, when a search returns a large number of results the first 15 are displayed. We group our hosts into clusters of 20, so it would be very convenient for us to see all hosts when we search for the prefix of 1 of them.
For example:
clusterA-00
clusterA-01
...
clusterA-18
clusterA-19
Right now if we search for 'clusterA' we see clusterA-00 - clusterA-14 on the first page and have to click through to see the final 5.
No database changes or third-party libraries are needed.
I have forked the repository and confirmed my changes have the expected result and pass both migrate.py test and travis-ci tests, but documentation states that I should submit a feature request before submitting a pull request.

Originally created by @reshippie on GitHub (Jul 10, 2018). <!-- Before opening a new issue, please search through the existing issues to see if your topic has already been addressed. Note that you may need to remove the "is:open" filter from the search bar to include closed issues. Check the appropriate type for your issue below by placing an x between the brackets. For assistance with installation issues, or for any other issues other than those listed below, please raise your topic for discussion on our mailing list: https://groups.google.com/forum/#!forum/netbox-discuss Please note that issues which do not fall under any of the below categories will be closed. Due to an excessive backlog of feature requests, we are not currently accepting any proposals which extend NetBox's feature scope. Do not prepend any sort of tag to your issue's title. An administrator will review your issue and assign labels as appropriate. ---> ### Issue type [X] Feature request <!-- An enhancement of existing functionality --> [ ] Bug report <!-- Unexpected or erroneous behavior --> [ ] Documentation <!-- A modification to the documentation --> [ ] Housekeeping <!-- Changes pertaining to the codebase itself --> <!-- Please describe the environment in which you are running NetBox. (Be sure to verify that you are running the latest stable release of NetBox before submitting a bug report.) If you are submitting a bug report and have made any changes to the code base, please first validate that your bug can be recreated while running an official release. --> ### Environment * Python version: 2.7.10 * NetBox version: 2.3.6-dev <!-- BUG REPORTS must include: * A list of the steps needed for someone else to reproduce the bug * A description of the expected and observed behavior * Any relevant error messages (screenshots may also help) FEATURE REQUESTS must include: * A detailed description of the proposed functionality * A use case for the new feature * A rough description of any necessary changes to the database schema * Any relevant third-party libraries which would be needed --> ### Description Currently, when a search returns a large number of results the first 15 are displayed. We group our hosts into clusters of 20, so it would be very convenient for us to see all hosts when we search for the prefix of 1 of them. For example: clusterA-00 clusterA-01 ... clusterA-18 clusterA-19 Right now if we search for 'clusterA' we see clusterA-00 - clusterA-14 on the first page and have to click through to see the final 5. No database changes or third-party libraries are needed. I have forked the repository and confirmed my changes have the expected result and pass both `migrate.py test` and travis-ci tests, but documentation states that I should submit a feature request before submitting a pull request.
adam added the status: duplicate label 2025-12-29 17:19:36 +01:00
adam closed this issue 2025-12-29 17:19:37 +01:00
Author
Owner

@jeremystretch commented on GitHub (Jul 10, 2018):

Should be covered by #1870

@jeremystretch commented on GitHub (Jul 10, 2018): Should be covered by #1870
Author
Owner

@reshippie commented on GitHub (Jul 10, 2018):

I'm not sure I explained my situation as clearly as I could. #1870 uses PAGINATE_COUNT in netbox/netbox/settings.py. I would like to take SEARCH_MAX_RESULTS out of netbox/netbox/views.py and add that into netbox/netbox/settings.py

@reshippie commented on GitHub (Jul 10, 2018): I'm not sure I explained my situation as clearly as I could. #1870 uses PAGINATE_COUNT in netbox/netbox/settings.py. I would like to take SEARCH_MAX_RESULTS out of netbox/netbox/views.py and add that into netbox/netbox/settings.py
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1835