starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

can't clear selection custom field #1635

New Issue
Closed
opened 2025-12-29 16:33:41 +01:00 by adam · 3 comments
adam commented 2025-12-29 16:33:41 +01:00
Owner
Copy Link

Originally created by @luto on GitHub (Mar 21, 2018).

Issue type

[ ] Feature request
[x] Bug report
[ ] Documentation

Environment

  • Python version: 2.7.5
  • NetBox version: 2.3.1

Description

Assuming there is a basic setup of manufacturer, sites, a device and so on.

  1. create a custom selection field with a couple of options
  2. edit an device and set the field, save
  3. edit the same device and try to clear the field (select ------), save
  4. receive an error 500 page :(

Sadly I can't reproduce this in the docker-compose setup.

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/contrib/auth/mixins.py", line 92, in dispatch
    return super(PermissionRequiredMixin, self).dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 88, in dispatch
    return handler(request, *args, **kwargs)
  File "/opt/netbox/netbox/utilities/views.py", line 196, in post
    obj = form.save()
  File "/opt/netbox/netbox/extras/forms.py", line 123, in save
    self._save_custom_fields()
  File "/opt/netbox/netbox/extras/forms.py", line 116, in _save_custom_fields
    cfv.save()
  File "/opt/netbox/netbox/extras/models.py", line 169, in save
    if self.pk and self.value is None:
  File "/opt/netbox/netbox/extras/models.py", line 161, in value
    return self.field.deserialize_value(self.serialized_value)
  File "/opt/netbox/netbox/extras/models.py", line 140, in deserialize_value
    return self.choices.get(pk=int(serialized_value))
ValueError: invalid literal for int() with base 10: ''

but funnily enough there is a check for exactly this case a few lines about the crash site:

if serialized_value is '':
    return None
Originally created by @luto on GitHub (Mar 21, 2018). ### Issue type [ ] Feature request <!-- An enhancement of existing functionality --> [x] Bug report <!-- Unexpected or erroneous behavior --> [ ] Documentation <!-- A modification to the documentation --> <!-- Please describe the environment in which you are running NetBox. (Be sure to verify that you are running the latest stable release of NetBox before submitting a bug report.) If you are submitting a bug report and have made any changes to the code base, please first validate that your bug can be recreated while running an official release. --> ### Environment * Python version: 2.7.5 * NetBox version: 2.3.1 <!-- BUG REPORTS must include: * A list of the steps needed for someone else to reproduce the bug * A description of the expected and observed behavior * Any relevant error messages (screenshots may also help) FEATURE REQUESTS must include: * A detailed description of the proposed functionality * A use case for the new feature * A rough description of any necessary changes to the database schema * Any relevant third-party libraries which would be needed --> ### Description Assuming there is a basic setup of manufacturer, sites, a device and so on. 1. create a custom selection field with a couple of options 2. edit an device and set the field, save 3. edit the same device and try to clear the field (select `------`), save 4. receive an error 500 page :( Sadly I can't reproduce this in the docker-compose setup. ``` Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner response = get_response(request) File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response response = self.process_exception_by_middleware(e, request) File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view return self.dispatch(request, *args, **kwargs) File "/usr/lib/python2.7/site-packages/django/contrib/auth/mixins.py", line 92, in dispatch return super(PermissionRequiredMixin, self).dispatch(request, *args, **kwargs) File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 88, in dispatch return handler(request, *args, **kwargs) File "/opt/netbox/netbox/utilities/views.py", line 196, in post obj = form.save() File "/opt/netbox/netbox/extras/forms.py", line 123, in save self._save_custom_fields() File "/opt/netbox/netbox/extras/forms.py", line 116, in _save_custom_fields cfv.save() File "/opt/netbox/netbox/extras/models.py", line 169, in save if self.pk and self.value is None: File "/opt/netbox/netbox/extras/models.py", line 161, in value return self.field.deserialize_value(self.serialized_value) File "/opt/netbox/netbox/extras/models.py", line 140, in deserialize_value return self.choices.get(pk=int(serialized_value)) ValueError: invalid literal for int() with base 10: '' ``` but funnily enough there is [a check for exactly this case](https://github.com/digitalocean/netbox/blob/develop/netbox/extras/models.py#L130-L131) a few lines about the crash site: ```python if serialized_value is '': return None ```
adam added the type: bugstatus: accepted labels 2025-12-29 16:33:41 +01:00
adam closed this issue 2025-12-29 16:33:42 +01:00
adam commented 2025-12-29 16:33:42 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Mar 21, 2018):

I just tested this on python 3.4 and did not get any errors. Given that it isn't reproducible in python 3.4 or on the docker setup, are you sure it isn't a problem with your setup somehow?

@DanSheps commented on GitHub (Mar 21, 2018): I just tested this on python 3.4 and did not get any errors. Given that it isn't reproducible in python 3.4 or on the docker setup, are you sure it isn't a problem with your setup somehow?
adam commented 2025-12-29 16:33:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 21, 2018):

This bug affects only Python 2.

@luto I can confirm that your PR #1981 fixes the issue. I believe the evaluation is performed using is because at one point the value was being compared against None rather than an empty string. Good catch!

@jeremystretch commented on GitHub (Mar 21, 2018): This bug affects only Python 2. @luto I can confirm that your PR #1981 fixes the issue. I _believe_ the evaluation is performed using `is` because at one point the value was being compared against `None` rather than an empty string. Good catch!
adam commented 2025-12-29 16:33:42 +01:00
Author
Owner
Copy Link

@luto commented on GitHub (Mar 21, 2018):

This bug affects only Python 2

I only later noticed that the docker setup is running the more sane py3, which is why I couldn't reproduce it 🤦‍♂️ Thanks for the quick merge! :)

@luto commented on GitHub (Mar 21, 2018): > This bug affects only Python 2 I only later noticed that the docker setup is running the more sane py3, which is why I couldn't reproduce it :man_facepalming: Thanks for the quick merge! :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1635
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?