[PR #21040] [CLOSED] Fix nested serializer validation for PATCH requests with {"id": X} format #16128

New Issue

adam · 2025-12-30T00:25:57+01:00

adam commented

2025-12-30 00:25:57 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/21040
Author: @casibbald
Created: 12/26/2025
Status: ❌ Closed

Base: main ← Head: fix/nested-serializer-tenant-validation

📝 Commits (1)

1189ef8 Fix nested serializer validation for PATCH requests with {"id": X} format

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 netbox/netbox/api/serializers/base.py (+13 -0)

📄 Description

When a nested serializer receives {"id": X} in a PATCH request, DRF was attempting to validate it as a full object, requiring all required fields (e.g., 'name' and 'group' for Tenant). This caused validation errors like 'group and name are required' even though the nested serializer should only look up the object by ID.

The fix overrides run_validation() to skip field-level validation for nested serializers, allowing to_internal_value() to properly handle {"id": X} format by looking up the object via get_related_object_by_attrs().

Fixes issue where PATCH requests to update Site with tenant field using {"id": X} format would fail with validation errors.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/21040 **Author:** [@casibbald](https://github.com/casibbald) **Created:** 12/26/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/nested-serializer-tenant-validation` --- ### 📝 Commits (1) - [`1189ef8`](https://github.com/netbox-community/netbox/commit/1189ef8ac9c81fa4c0480710bd48e2e6d1c539d4) Fix nested serializer validation for PATCH requests with {"id": X} format ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/api/serializers/base.py` (+13 -0) </details> ### 📄 Description When a nested serializer receives {"id": X} in a PATCH request, DRF was attempting to validate it as a full object, requiring all required fields (e.g., 'name' and 'group' for Tenant). This caused validation errors like 'group and name are required' even though the nested serializer should only look up the object by ID. The fix overrides run_validation() to skip field-level validation for nested serializers, allowing to_internal_value() to properly handle {"id": X} format by looking up the object via get_related_object_by_attrs(). Fixes issue where PATCH requests to update Site with tenant field using {"id": X} format would fail with validation errors.   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:25:57 +01:00

adam closed this issue

2025-12-30 00:25:57 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#16128